Skip to content
This repository has been archived by the owner on Mar 11, 2023. It is now read-only.

Class refactor for clearer view #23

Merged
merged 29 commits into from
Dec 11, 2019
Merged

Class refactor for clearer view #23

merged 29 commits into from
Dec 11, 2019

Commits on Dec 10, 2019

  1. Class refactoring WIP

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    9f2bc03 View commit details
    Browse the repository at this point in the history

  2. Added new PoFile vars

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    7a7b2cf View commit details
    Browse the repository at this point in the history

  3. Big refactor + disabled matching files

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    14fbdd3 View commit details
    Browse the repository at this point in the history

  4. Version bump

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    2f506ea View commit details
    Browse the repository at this point in the history

  5. Removed useless code and one useless TODO

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    90d8458 View commit details
    Browse the repository at this point in the history

  6. Removed commented code 

    cc @deronnax. It is commited in another branch for later.
    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    f46e5a9 View commit details
    Browse the repository at this point in the history

  7. Added comments

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    21fe4c4 View commit details
    Browse the repository at this point in the history

  8. Blackified the code

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    f8d352f View commit details
    Browse the repository at this point in the history

  9. Added type hinting + black project config

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    ba196ff View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
    @Seluj78 @awecx
    Seluj78 and awecx committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    7307a10 View commit details
    Browse the repository at this point in the history

  11. Feedback from @awecx. 

    Although have to convert to string as it returns bytes...
    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    0705eba View commit details
    Browse the repository at this point in the history

  12. More feedback from @awecx

    @Seluj78
    Seluj78 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    658ee23 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Julien Palard <julien@palard.fr>
    @Seluj78 @JulienPalard
    Seluj78 and JulienPalard committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    a0cd2f9 View commit details
    Browse the repository at this point in the history

  2. Like black or leave it 

    cc @JulienPalard
    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    f9154eb View commit details
    Browse the repository at this point in the history

  3. Fixes from code review

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fd4dacc View commit details
    Browse the repository at this point in the history

  4. Standard docstrings + black 

    cc @JulienPalard
    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    cfa396d View commit details
    Browse the repository at this point in the history

  5. class PoFile -> PoFileStats

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    76654b3 View commit details
    Browse the repository at this point in the history

  6. Fixed string replacing problem

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    36ff67e View commit details
    Browse the repository at this point in the history

  7. Changed return type to Mapping

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    d4fb2fe View commit details
    Browse the repository at this point in the history

  8. Changed return type hint form dict to mapping 

    Based on code review feedback
    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    4704aff View commit details
    Browse the repository at this point in the history

  9. Removed useless code

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    b05b7bf View commit details
    Browse the repository at this point in the history

  10. Back to str.replace()

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    8dfd0b8 View commit details
    Browse the repository at this point in the history

  11. Update potodo/_po_file.py

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    20427b8 View commit details
    Browse the repository at this point in the history

  12. Update potodo/_github.py

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    0702d50 View commit details
    Browse the repository at this point in the history

  13. Followed code review. Removed useless type annotation

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    1ff37ba View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/class-refactor' into class-refactor

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    0faea86 View commit details
    Browse the repository at this point in the history

  15. Removed another useless type anotation

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    140f7b6 View commit details
    Browse the repository at this point in the history

  16. Black, mypy and removed useless returns as lists are passed as refere… 

    …nces
    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    1feda28 View commit details
    Browse the repository at this point in the history

  17. Fixed mypy error

    @Seluj78
    Seluj78 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    4b03d33 View commit details
    Browse the repository at this point in the history