-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop -> Master #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During conversion from PDDL domain to string, the actions were printed without the ":action" tag. This commit adds the tag and removes the (wrong) upper level tag ":actions"
fix: missing `:action` tag
tick 'derived-predicates' and 'conditional-effects' in 'Features' README section
…ditional-effects Add support for derived predicates and conditional effects
Fix/issues
Bringing into `develop` branch some changes that were left only on `master`.
- add lower and upper bounds to several development tools and depdendencies in Pipfile and tox.ini: black, isort, flake8, pytest, etc. - (Temporarily) remove darglint checker from the linting dev workflow - Update Pipfile.lock according to the previous point - Run black against the source code
- domain-to-string and problem-to-string functions now also print types, and README examples have been updated accordingly. - domain_name private attr in Domain cls was not processed correctly.
Fix linting and tests
This commit changes: - the LICENSE file from LGPL v3.0 to MIT - the copyright license header in all files, following Google Open Source directives: https://opensource.google/documentation/reference/releasing/licenses - the scripts/check_copyright.py, in accordance with the above - update other Python package metadata and the README
Update project license from LGPL to MIT
marcofavorito
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge all new features/fixes and license changes to the master branch.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.Further comments
None