Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data catalog - HUE #27

Merged
merged 11 commits into from
Nov 2, 2020
Merged

Data catalog - HUE #27

merged 11 commits into from
Nov 2, 2020

Conversation

tumido
Copy link
Member

@tumido tumido commented Oct 21, 2020

Part of DATAHUB-2295

This converts the Hue component to kustomize base.

I'm introducing this layout:

  1. within data-catalog/base I've created a folder for hue manifests and split the resources into individual files
  2. ConfigMaps like hue.ini are converted to Secrets, since they contain credentials and we can't template and encrypt those unless we use any additional plugins...
  3. New data-catalog/overlays/dev structure was created for the dev overlays. (Just dev for now - once we have that, we can move to next stages).
  4. I've introduced .sops.yaml for datacatalog - it's the same as anywhere else in the Internal DH - the same encryption key is used.
  5. The dev overlay contains sops encrypted secret definitions which should contain all the values which used to be set in vars/dev-vars.yaml and vars/common-vars.yaml.
  6. Some vars/common-vars.yaml values are set in the data-catalog/base/hue/kustomization.yaml, since I expect those values to be shared, yet worth making them configurable.

Few uncertainties:

  • in data-catalog/base/hue I'm using and image name transformer which may not work fine for DeploymentConfig image change trigger - there's no way to inject the namespace key, so I hope the ImageStreamTag can pick up name in format namespace/image:tag.
  • I'm not sure if I've replaced all the setting correctly, please check.

To verify the build result run:

kustomize build --enable_alpha_plugins data-catalog/overlays/dev

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 21, 2020
@tumido
Copy link
Member Author

tumido commented Oct 21, 2020

cc @maulikjs @4n4nd

@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2020
@sesheta
Copy link

sesheta commented Oct 21, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

1 similar comment
@sesheta
Copy link

sesheta commented Oct 21, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@accorvin
Copy link
Member

@tumido Would it make more sense to try and get this into the upstream ODH instead of our internal-specific repo? I think the right place would be https://github.com/opendatahub-io/odh-manifests

@sesheta
Copy link

sesheta commented Oct 21, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@tumido
Copy link
Member Author

tumido commented Oct 21, 2020

hm.. as per your email @accorvin I thought you'd like to see it here first, so we can resolve DATAHUB-2295 quickly and then move it to ODH. Did I misunderstood? I'm confused now. 😄

cc @maulikjs @durandom

@accorvin
Copy link
Member

hm.. as per your email @accorvin I thought you'd like to see it here first, so we can resolve DATAHUB-2295 quickly and then move it to ODH. Did I misunderstood? I'm confused now. 😄

cc @maulikjs @durandom

@tumido you are right. I forgot about that part.

@maulikjs
Copy link

Hey @tumido This looks good,
I will try and deploy this on stage and add comments here if any.

@sesheta
Copy link

sesheta commented Oct 21, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@tumido
Copy link
Member Author

tumido commented Oct 21, 2020

I've converted/added the prod environments, and I have found one curious thing. The Hue DeploymentConfig's resources/{requests,limits}/{cpu,memory} seems to be modified in prod var file only and in usir/ccx/customer-journey prod envs the base values are left as is. Is that correct observation?

@tumido
Copy link
Member Author

tumido commented Oct 21, 2020

Btw, please check all those secrets in each overlay twice after me. It's been so much copy pasting that I sure made a mistake somewhere...

@tumido tumido changed the title [WIP] Data catalog - HUE Data catalog - HUE Oct 21, 2020
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@sesheta
Copy link

sesheta commented Oct 22, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@sesheta
Copy link

sesheta commented Oct 22, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@sesheta
Copy link

sesheta commented Oct 22, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@sesheta
Copy link

sesheta commented Oct 22, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@sesheta
Copy link

sesheta commented Oct 23, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@maulikjs
Copy link

maulikjs commented Oct 28, 2020

@tumido
I am unable to render this.

kustomize build --enable_alpha_plugins overlays/dev
Error: accumulating resources: accumulateFile "accumulating resources from './hue': '/Users/mshah/work/datahub/temp/tumido/odh-manifests/data-catalog/overlays/dev/hue' must resolve to a file", accumulateDirector: "recursed accumulation of path '/Users/mshah/work/datahub/temp/tumido/odh-manifests/data-catalog/overlays/dev/hue': accumulating resources: accumulateFile \"accumulating resources from '../../../base/hue': '/Users/mshah/work/datahub/temp/tumido/odh-manifests/data-catalog/base/hue' must resolve to a file\", accumulateDirector: \"recursed accumulation of path '/Users/mshah/work/datahub/temp/tumido/odh-manifests/data-catalog/base/hue': accumulating resources: accumulateFile \\\"accumulating resources from 'hue-mysql-dc.yaml': YAML file [hue-mysql-dc.yaml] encounters a format error.\\\\nerror converting YAML to JSON: yaml: line 26: did not find expected key\\\\n\\\", loader.New \\\"error loading hue-mysql-dc.yaml with git: url lacks orgRepo: hue-mysql-dc.yaml, dir: got file 'hue-mysql-dc.yaml', but '/Users/mshah/work/datahub/temp/tumido/odh-manifests/data-catalog/base/hue/hue-mysql-dc.yaml' must be a directory to be a root, get: invalid source string: hue-mysql-dc.yaml\\\"\""

Any idea as to what might be going on?

@tumido
Copy link
Member Author

tumido commented Oct 29, 2020

No ideal @maulikjs are you sure you're on the branch/latest commit?

$ git rev-parse --short HEAD
c9de1e8

$ kustomize build --enable_alpha_plugins data-catalog/overlays/dev 1>/dev/null && echo 'Success'
2020/10/29 12:51:12 Attempting plugin load from '/home/tcoufal/.config/kustomize/plugin/viaduct.ai/v1/ksops/ksops.so'
Success

What kustomize version you're running on?

@maulikjs
Copy link

I was being stupid. I was not on the latest commit 🤦
Reviewing now

@sesheta
Copy link

sesheta commented Nov 2, 2020

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing kafka/README.md
Fixing jupyterhub/bases/custom-images/jupyterhub-custom-images.yaml

Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed

@maulikjs
Copy link

maulikjs commented Nov 2, 2020

Thanks for the changes @tumido ! Works now
/approve

@anishasthana
Copy link

/approve

@sesheta
Copy link

sesheta commented Nov 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, maulikjs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@sesheta sesheta merged commit c2d71e5 into AICoE:data-catalog Nov 2, 2020
@maulikjs maulikjs mentioned this pull request Nov 2, 2020
maulikjs pushed a commit that referenced this pull request Nov 2, 2020
* Split hue base to manageable yaml files

* Add dev overlays for Hue

* Remove hue base manifest dump

* Add stage overlays

* Add prod environments

* Change namespaces in hue.ini in overlays

* Fix selectors for Services

* Fix s/name/secretName/ in volumes

* Cleanup secret-generator names in overlays

* Fix: wrong indent

* Patch mysql-dc for ImageChange trigger
sesheta pushed a commit that referenced this pull request Nov 4, 2020
* Add data-catalog

* Data catalog - HUE (#27)

* Split hue base to manageable yaml files

* Add dev overlays for Hue

* Remove hue base manifest dump

* Add stage overlays

* Add prod environments

* Change namespaces in hue.ini in overlays

* Fix selectors for Services

* Fix s/name/secretName/ in volumes

* Cleanup secret-generator names in overlays

* Fix: wrong indent

* Patch mysql-dc for ImageChange trigger

* Data Catalog - Thriftserver (#29)

* Add Thriftserver base

* Add dev overlays

* Add stage overlays

* Add prod-* overlays

* Cleanup: remove vars

* Enlist thriftserver overlays

* Patch postgres dc for ImageChange trigger

Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>

* Fix selectors in deploymentconfigs

* Fix selectors in services

* Fix selectors in data catalog again

* Reset hue.ini to include all fields

Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com>
Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
@tumido tumido deleted the data-catalog branch November 11, 2020 11:56
chauhankaranraj pushed a commit to chauhankaranraj/idh-manifests that referenced this pull request Jan 19, 2021
* Add data-catalog

* Data catalog - HUE (AICoE#27)

* Split hue base to manageable yaml files

* Add dev overlays for Hue

* Remove hue base manifest dump

* Add stage overlays

* Add prod environments

* Change namespaces in hue.ini in overlays

* Fix selectors for Services

* Fix s/name/secretName/ in volumes

* Cleanup secret-generator names in overlays

* Fix: wrong indent

* Patch mysql-dc for ImageChange trigger

* Data Catalog - Thriftserver (AICoE#29)

* Add Thriftserver base

* Add dev overlays

* Add stage overlays

* Add prod-* overlays

* Cleanup: remove vars

* Enlist thriftserver overlays

* Patch postgres dc for ImageChange trigger

Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>

* Fix selectors in deploymentconfigs

* Fix selectors in services

* Fix selectors in data catalog again

* Reset hue.ini to include all fields

Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com>
Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants