-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data catalog - HUE #27
Conversation
Pre-Commit Test failed! Click here
|
1 similar comment
Pre-Commit Test failed! Click here
|
@tumido Would it make more sense to try and get this into the upstream ODH instead of our internal-specific repo? I think the right place would be https://github.com/opendatahub-io/odh-manifests |
Pre-Commit Test failed! Click here
|
hm.. as per your email @accorvin I thought you'd like to see it here first, so we can resolve DATAHUB-2295 quickly and then move it to ODH. Did I misunderstood? I'm confused now. 😄 |
@tumido you are right. I forgot about that part. |
Hey @tumido This looks good, |
Pre-Commit Test failed! Click here
|
I've converted/added the prod environments, and I have found one curious thing. The Hue DeploymentConfig's |
Btw, please check all those secrets in each overlay twice after me. It's been so much copy pasting that I sure made a mistake somewhere... |
Pre-Commit Test failed! Click here
|
Pre-Commit Test failed! Click here
|
Pre-Commit Test failed! Click here
|
Pre-Commit Test failed! Click here
|
Pre-Commit Test failed! Click here
|
@tumido
Any idea as to what might be going on? |
No ideal @maulikjs are you sure you're on the branch/latest commit?
What |
I was being stupid. I was not on the latest commit 🤦 |
Pre-Commit Test failed! Click here
|
Thanks for the changes @tumido ! Works now |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, maulikjs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Split hue base to manageable yaml files * Add dev overlays for Hue * Remove hue base manifest dump * Add stage overlays * Add prod environments * Change namespaces in hue.ini in overlays * Fix selectors for Services * Fix s/name/secretName/ in volumes * Cleanup secret-generator names in overlays * Fix: wrong indent * Patch mysql-dc for ImageChange trigger
* Add data-catalog * Data catalog - HUE (#27) * Split hue base to manageable yaml files * Add dev overlays for Hue * Remove hue base manifest dump * Add stage overlays * Add prod environments * Change namespaces in hue.ini in overlays * Fix selectors for Services * Fix s/name/secretName/ in volumes * Cleanup secret-generator names in overlays * Fix: wrong indent * Patch mysql-dc for ImageChange trigger * Data Catalog - Thriftserver (#29) * Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com> * Fix selectors in deploymentconfigs * Fix selectors in services * Fix selectors in data catalog again * Reset hue.ini to include all fields Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
* Add data-catalog * Data catalog - HUE (AICoE#27) * Split hue base to manageable yaml files * Add dev overlays for Hue * Remove hue base manifest dump * Add stage overlays * Add prod environments * Change namespaces in hue.ini in overlays * Fix selectors for Services * Fix s/name/secretName/ in volumes * Cleanup secret-generator names in overlays * Fix: wrong indent * Patch mysql-dc for ImageChange trigger * Data Catalog - Thriftserver (AICoE#29) * Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com> * Fix selectors in deploymentconfigs * Fix selectors in services * Fix selectors in data catalog again * Reset hue.ini to include all fields Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
Part of DATAHUB-2295
This converts the Hue component to
kustomize
base.I'm introducing this layout:
data-catalog/base
I've created a folder forhue
manifests and split the resources into individual filesConfigMaps
likehue.ini
are converted toSecrets
, since they contain credentials and we can't template and encrypt those unless we use any additional plugins...data-catalog/overlays/dev
structure was created for thedev
overlays. (Justdev
for now - once we have that, we can move to next stages)..sops.yaml
for datacatalog - it's the same as anywhere else in the Internal DH - the same encryption key is used.dev
overlay containssops
encrypted secret definitions which should contain all the values which used to be set invars/dev-vars.yaml
andvars/common-vars.yaml
.vars/common-vars.yaml
values are set in thedata-catalog/base/hue/kustomization.yaml
, since I expect those values to be shared, yet worth making them configurable.Few uncertainties:
data-catalog/base/hue
I'm using and image name transformer which may not work fine forDeploymentConfig
image change trigger - there's no way to inject thenamespace
key, so I hope theImageStreamTag
can pick up name in formatnamespace/image:tag
.To verify the build result run: