-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Catalog - Thriftserver #29
Conversation
Pre-Commit Test failed! Click here
|
Tested this out and works great! Thank you sooooo much @tumido, we are good to merge this in! |
/approve |
/assign @HumairAK |
Btw, both of those PR's are against the data catalog branch. Once both are merged we'd need to merge it all back to production. |
Yup Yup @tumido |
Pre-Commit Test failed! Click here
|
Thanks for the changes @tumido, works now! |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, maulikjs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com>
* Add data-catalog * Data catalog - HUE (#27) * Split hue base to manageable yaml files * Add dev overlays for Hue * Remove hue base manifest dump * Add stage overlays * Add prod environments * Change namespaces in hue.ini in overlays * Fix selectors for Services * Fix s/name/secretName/ in volumes * Cleanup secret-generator names in overlays * Fix: wrong indent * Patch mysql-dc for ImageChange trigger * Data Catalog - Thriftserver (#29) * Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com> * Fix selectors in deploymentconfigs * Fix selectors in services * Fix selectors in data catalog again * Reset hue.ini to include all fields Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
* Add data-catalog * Data catalog - HUE (AICoE#27) * Split hue base to manageable yaml files * Add dev overlays for Hue * Remove hue base manifest dump * Add stage overlays * Add prod environments * Change namespaces in hue.ini in overlays * Fix selectors for Services * Fix s/name/secretName/ in volumes * Cleanup secret-generator names in overlays * Fix: wrong indent * Patch mysql-dc for ImageChange trigger * Data Catalog - Thriftserver (AICoE#29) * Add Thriftserver base * Add dev overlays * Add stage overlays * Add prod-* overlays * Cleanup: remove vars * Enlist thriftserver overlays * Patch postgres dc for ImageChange trigger Co-authored-by: Maulik Shah <maulik.shah1995@gmail.com> * Fix selectors in deploymentconfigs * Fix selectors in services * Fix selectors in data catalog again * Reset hue.ini to include all fields Co-authored-by: Tomáš Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tomas Coufal <tcoufal@redhat.com>
Related to: #27 (either of them will need a rebase, if the other is merged)
Part of: DATAHUB-2295
This converts the Thriftserver component to
kustomize
base.The layout is the same as for the Hue component in #27
data-catalog/base/thriftserver
are all the manifests needed for Thriftserverdata-catalog/base/thriftserver/kustomization.yaml
, allows to specify image version + adds aapp=thriftserver
labelConfigMap
s which contained sensitive data - (like db passwords) are transformed toSecrets
and mounted in theDeploymentConfigs
accordinglystorage-class
onPVC
s