Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Argo to 2.12.5 and use upstream images again #77

Merged
merged 2 commits into from
Jan 25, 2021
Merged

feat: Update Argo to 2.12.5 and use upstream images again #77

merged 2 commits into from
Jan 25, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Jan 21, 2021

This will make us use upstream images from argoproj quay again + bumps the version few patch releases.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2021
@tumido
feat: Update Argo to 2.12.5 and use upstream images again
f1c741a 
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
anishasthana
anishasthana approved these changes Jan 22, 2021
View reviewed changes
Copy link

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build succeeded and the OpenShift objects look correct. Thanks Tom!

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@tumido
Copy link
Member Author

tumido commented Jan 22, 2021

This PR will allow us to revert to upstream images and cleanup the odh quay repo duplicity. We'll match current ODH master with this PR.

The this patch release doesn't fix the "forbidden" cosmetic bug mentioned at opendatahub-io#208

@anishasthana
Copy link

@tumido the commits here look.... odd

@tumido
Copy link
Member Author

tumido commented Jan 25, 2021 •
edited
Loading

@anishasthana I think @goern just rebased my PR using the GitHub button, which is usually on the same place as the "Merge" button. I don't see any harm in the commit though. I bet @goern doesn't mean to sabotage this PR. 😄

@goern
Copy link
Member

goern commented Jan 25, 2021

Ja 😁

@tumido
Copy link
Member Author

tumido commented Jan 25, 2021

Seems like Prow is on fire because of this PR for some reason:
image

Closing for now and hoping it'll help.

@tumido tumido closed this Jan 25, 2021
@tumido tumido reopened this Jan 25, 2021
@goern goern mentioned this pull request Jan 25, 2021
Open
4 tasks
@goern
Copy link
Member

goern commented Jan 25, 2021

/hold until we have the 2nd GitHub approval

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
@sesheta
Copy link

sesheta commented Jan 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [anishasthana,gmfrasca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anishasthana
Copy link

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
@sesheta sesheta merged commit 993c22e into AICoE:production Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana approved these changes

@gmfrasca gmfrasca gmfrasca approved these changes

@accorvin accorvin Awaiting requested review from accorvin

@maulikjs maulikjs Awaiting requested review from maulikjs

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tumido @anishasthana @goern @sesheta @gmfrasca