-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kustomize artifacts for deploying rsyslog #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment above, but other than that lgtm!
rsyslog/bases/rsyslog/rsyslog.yaml
Outdated
source: | ||
git: | ||
ref: master | ||
uri: https://gitlab.cee.redhat.com/data-hub/dh-rsyslog.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bring the contents of this repository out as well? Or should it stay internal for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anishasthana I've been trying to think of a good solution for that. If I can get a repo set up in a good spot in Quay, what do you think of moving this code to this repo then setting up a quay build for it rather than building the image in a build config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I've added the image build artifacts to this PR and updated the buildconfig to point to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that.
f7d17b6
to
070b330
Compare
I think you're missing the .sops.yaml file included in the target-env folders that use sops, could you add those? |
@HumairAK Ah, good catch. I missed that when copying files over from the old PR since it's a hidden file. Is it supposed to be in the target env directories, or just the main rsyslog directory? I've added it in this PR now in the main rsyslog directory, which looked like how it was done in other examples. |
@accorvin it depends on your use case, so if stage/prod are encrypted using different gpg fingerprints then you'd use .sops.yaml for each directory (sops looks for the closest .sops.yaml in the file tree hierarchy), same if you have a different regex or other configs In your case I see they are encrypted using the same key, so one in the top level rsyslog directory should be fine! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anishasthana, HumairAK The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.