Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kustomize artifacts for deploying rsyslog #1

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

accorvin
Copy link
Member

No description provided.

@todo
Copy link

todo bot commented Sep 29, 2020

move PID to top level

# The imjournal normalized _PID to pid in its message properties. TODO: move PID to top level
set $.fwdpid = $!pid;
} else {
if strlen($!_PID) > 0 then {
set $.fwdpid = $!_PID;
}


This comment was generated by todo based on a TODO comment in efb42d0 in #1. cc @accorvin.

Copy link
Contributor

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment above, but other than that lgtm!

rsyslog/README.md Outdated Show resolved Hide resolved
rsyslog/README.md Outdated Show resolved Hide resolved
source:
git:
ref: master
uri: https://gitlab.cee.redhat.com/data-hub/dh-rsyslog.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bring the contents of this repository out as well? Or should it stay internal for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anishasthana I've been trying to think of a good solution for that. If I can get a repo set up in a good spot in Quay, what do you think of moving this code to this repo then setting up a quay build for it rather than building the image in a build config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I've added the image build artifacts to this PR and updated the buildconfig to point to them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

@accorvin accorvin self-assigned this Sep 30, 2020
@HumairAK
Copy link
Contributor

HumairAK commented Sep 30, 2020

I think you're missing the .sops.yaml file included in the target-env folders that use sops, could you add those?

@accorvin
Copy link
Member Author

I think you're missing the .sops.yaml file included in the target-env folders that use sops, could you add those?

@HumairAK Ah, good catch. I missed that when copying files over from the old PR since it's a hidden file.

Is it supposed to be in the target env directories, or just the main rsyslog directory? I've added it in this PR now in the main rsyslog directory, which looked like how it was done in other examples.

@HumairAK
Copy link
Contributor

HumairAK commented Sep 30, 2020

@accorvin it depends on your use case, so if stage/prod are encrypted using different gpg fingerprints then you'd use .sops.yaml for each directory (sops looks for the closest .sops.yaml in the file tree hierarchy), same if you have a different regex or other configs

In your case I see they are encrypted using the same key, so one in the top level rsyslog directory should be fine!

@sesheta
Copy link

sesheta commented Sep 30, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anishasthana, HumairAK
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@accorvin accorvin merged commit a380d28 into AICoE:master Sep 30, 2020
@todo todo bot mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants