Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jupyterhub_total_users to Obslytics metric list #84

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Add jupyterhub_total_users to Obslytics metric list #84

merged 1 commit into from
Aug 27, 2021

Conversation

gmfrasca
Copy link
Member

No description provided.

@todo
Copy link

todo bot commented Aug 26, 2021

should we remove this and update to a CHANGME value? it should always be overlayed.

internal-data-hub/obslytics/bases/triggers.yaml

Lines 19 to 22 in af27b5f

# TODO: should we remove this and update to a CHANGME value? it _should_ always be overlayed.
value: '[
"ceph_cluster_total_bytes",
"ceph_cluster_total_used_raw_bytes",

This comment was generated by todo based on a TODO comment in af27b5f in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

should we remove this and update to a CHANGME value? it should always be overlayed.

internal-data-hub/obslytics/bases/triggers.yaml

Lines 92 to 95 in af27b5f

withItems: # TODO: should we remove this and update to a CHANGME value? it _should_ always be overlayed.
- ceph_cluster_total_bytes
- ceph_cluster_total_used_raw_bytes
- cluster_infrastructure_provider

This comment was generated by todo based on a TODO comment in af27b5f in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

should we remove this and update to a CHANGME value? it should always be overlayed.

internal-data-hub/obslytics/bases/triggers.yaml

Lines 137 to 140 in af27b5f

withItems: # TODO: should we remove this and update to a CHANGME value? it _should_ always be overlayed.
- ceph_cluster_total_bytes
- ceph_cluster_total_used_raw_bytes
- cluster_infrastructure_provider

This comment was generated by todo based on a TODO comment in af27b5f in #84. cc @gmfrasca.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2021
anishasthana
anishasthana suggested changes Aug 26, 2021
View reviewed changes
obslytics/overlays/prod/triggers.yaml Show resolved Hide resolved
obslytics/bases/triggers.yaml Outdated Show resolved Hide resolved
@gmfrasca
Add rhods_total_users and rhods_aggregate_availability to Obslytics m…
320e493 
…etric list

- Add rhods_total_users and rhods_aggregate_availability metrics to prod metric lists
- Also added csv_succeeded to prod overlay, which appears to be missing by mistake
@todo
Copy link

todo bot commented Aug 26, 2021

times out

internal-data-hub/obslytics/overlays/prod/triggers.yaml

Lines 29 to 32 in 320e493

# "cluster_operator_conditions", # TODO: times out
- op: replace
path: /spec/templates/1/steps/1/0/withItems
value:

This comment was generated by todo based on a TODO comment in 320e493 in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

add the following metrics to this list

internal-data-hub/obslytics/overlays/prod/triggers.yaml

Lines 55 to 59 in 320e493

# TODO: add the following metrics to this list
# - cluster_operator_conditions # TODO: times out
- op: replace
path: /spec/templates/2/steps/0/0/withItems
value:

This comment was generated by todo based on a TODO comment in 320e493 in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

times out

internal-data-hub/obslytics/overlays/prod/triggers.yaml

Lines 56 to 59 in 320e493

# - cluster_operator_conditions # TODO: times out
- op: replace
path: /spec/templates/2/steps/0/0/withItems
value:

This comment was generated by todo based on a TODO comment in 320e493 in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

add the following metrics to this list

internal-data-hub/obslytics/overlays/prod/triggers.yaml

Lines 82 to 83 in 320e493

# TODO: add the following metrics to this list
# - cluster_operator_conditions # TODO: times out

This comment was generated by todo based on a TODO comment in 320e493 in #84. cc @gmfrasca.

@todo
Copy link

todo bot commented Aug 26, 2021

times out

internal-data-hub/obslytics/overlays/prod/triggers.yaml

Line 83 in 320e493

# - cluster_operator_conditions # TODO: times out

This comment was generated by todo based on a TODO comment in 320e493 in #84. cc @gmfrasca.

@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2021
anishasthana
anishasthana reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2021
@rimolive
Copy link
Member

/approve

@sesheta
Copy link

sesheta commented Aug 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@sesheta sesheta merged commit 1954097 into AICoE:main Aug 27, 2021
@todo todo bot mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana requested changes

@lucferbux lucferbux Awaiting requested review from lucferbux

@accorvin accorvin Awaiting requested review from accorvin

@maulikjs maulikjs Awaiting requested review from maulikjs

Assignees

@anishasthana anishasthana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmfrasca @rimolive @sesheta @anishasthana