Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exception handling for main async loop #72

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

goern
Copy link
Member

@goern goern commented Sep 14, 2020

Signed-off-by: Christoph Görn goern@redhat.com

Related Issues and Dependencies

DNS resolution problems on cluster lead to failed handling of webhooks received.

This introduces a breaking change

  • Yes
  • No

Signed-off-by: Christoph Görn <goern@redhat.com>
@todo
Copy link

todo bot commented Sep 14, 2020

add a error/exception metric inc here, and in general a metric exporter

# TODO add a error/exception metric inc here, and in general a metric exporter
_LOGGER.exception(gai)


This comment was generated by todo based on a TODO comment in 8c95bc9 in #72. cc @goern.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@sesheta
Copy link
Contributor

sesheta commented Oct 27, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants