adding a layered calorimeter struct that copes with conical calorimeters

[Voutsi]

BEGINRELEASENOTES

• modifying the LayeredCalorimeterData struct in order to cope with conical shaped calorimeters

ENDRELEASENOTES

[petricm]

As far as I see this is identical to the not conical with the difference that double extent[6] ; instead of double extent[4] ;. Wouldn't it then be better to modify LayeredCalorimeterStruct and put an if in the overloading checking if the two last fields are filled?

[petricm]

Why are you even putting it in if it is deprecated?

[petricm]

What's the purpose of this comment?

[petricm]

White space change, please remove.

[petricm]

$Is is a SVN tag

[gaede]

Could we not simply have:

      /// enum for encoding the sensor type in typeFlags
      enum LayoutType{
	BarrelLayout=0,
	EndcapLayout,
        ConicalLayout
      };

      /// type of layout: BarrelLayout, EndcapLayout or ConicalLayout
      LayoutType layoutType ;

      /** extent of the calorimeter in the r-z-plane [ rmin, rmax, zmin, zmax, rmin2, rmax2 ] in mm.
         * where rmin2, rmax2 are the radii at zmax for the ConicalLayout and not used else.
         */
      double extent[6] ;

[petricm]

I agree, and then you can use ConicalLayout in the overloading of <<

[Voutsi]

Thanks for your suggestions, I modified accordingly.

[petricm]

@Voutsi please modify(edit comment) in the initial comment in the release notes tag to reflect the actual change.

[Voutsi]

release notes updated