Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installation for Slicer Radiomics not working #23

Closed
JoostJM opened this issue Jun 14, 2017 · 15 comments
Closed

Windows installation for Slicer Radiomics not working #23

JoostJM opened this issue Jun 14, 2017 · 15 comments
Assignees
Labels

Comments

@JoostJM
Copy link
Contributor

JoostJM commented Jun 14, 2017

When installing SlicerRadiomics from extension manager, installation works, however, the module cannot be loaded due to an error with the pyYAML library. When you comment out import pykwalify in featureextractor.py (in the installed site-packages), module loads fine and works without issue (pykwalify not needed in slicer extension)

@pieper
Copy link
Collaborator

pieper commented Jun 19, 2017

Until this is fixed, the file to change:

C:/Users/username/AppData/Roaming/NA-MIC/Extensions-revision/SlicerRadiomics/lib/site-packages/radiomics/featureextractor.py

Where revision is something like 26083 depending on the nightly version of Slicer.

Line 9 should be changed from:

import pykwalify.core

to:

# import pykwalify.core

@pieper
Copy link
Collaborator

pieper commented Jun 19, 2017

@pieper
Copy link
Collaborator

pieper commented Jul 15, 2017

@JoostJM was this issue fixed by d0a77c?

@JoostJM
Copy link
Contributor Author

JoostJM commented Jul 17, 2017

@pieper, d0a77c presents a temporary workaround. Additionally, that fix won't take effect until the extension is rebuilt and repackaged.

@fedorov
Copy link
Collaborator

fedorov commented Jul 17, 2017

Joost, the extension is rebuilt and packaged automatically on each source code update.

@pieper
Copy link
Collaborator

pieper commented Jul 17, 2017

I just tested the current nightly build on windows (2017-07-16) and confirmed that the Radiomics extension is working as expected. So the workaround is in place but the underlying issue remains.

@jcfr
Copy link
Collaborator

jcfr commented Sep 29, 2017

Now #16 is fixed, I will address this next week.

@JoostJM
Copy link
Contributor Author

JoostJM commented Nov 13, 2017

@jcfr, what is the status of this issue?

@jcfr
Copy link
Collaborator

jcfr commented Nov 13, 2017 via email

@renjiliang
Copy link

I have installed radiomics extension,but the following bug was always appeared. How to resolve the problem?

File "C:/Users/Administrator/AppData/Roaming/NA-MIC/Extensions-26309/SlicerRadiomics/lib/Slicer-4.7/qt-scripted-modules/SlicerRadiomics.py", line 535, in run
enabledImageTypes)
File "C:/Users/Administrator/AppData/Roaming/NA-MIC/Extensions-26309/SlicerRadiomics/lib/Slicer-4.7/qt-scripted-modules/SlicerRadiomics.py", line 448, in calculateFeatures
extractor.disableAllImagesTypes()

@renjiliang
Copy link

I did not find import "pykwalify.core" in file featureextractor

@JoostJM
Copy link
Contributor Author

JoostJM commented Dec 4, 2017

@renjiliang, That's correct, pykwalify.core is currently disabled due to this issue. We are working on a fix. The error you received is unrelated and due to a typo bug in the SlicerRadiomics Code. I corrected this just now in 8c4ffc7. This change will be incorporated in tonights nightly build of slicer, so to fix it, reinstall the latest nightly of slicer tomorrow, or apply the fix yourself in the SlicerRadiomics python file, which is located somewhere in C:\Users\<USER>\AppData\Roaming\NA-MIC\Extensions-26442\SlicerRadiomics\Lib\Slicer-4.7\qt-scripted-modules (It is possible that the extensions number is different, but the NA-MIC folder contains all your installed Slicer Extensions, including SlicerRadiomics).

fedorov referenced this issue Dec 4, 2017
In the code, after the feature extractor is instantiated, all image types are disabled, after which only the enabled ones are re-enabled. This call was updated in 70f3c62 to reflect recent changes to function names in PyRadiomics.
However, the update contained a bug, as the function in question is called `disableAllImageTypes` and not `disableAllImagesTypes` (additional 's').
@fedorov
Copy link
Collaborator

fedorov commented Dec 8, 2017

It looks like now build is failing because a warning is interpreted as an error:

http://slicer.cdash.org/viewBuildError.php?buildid=1148769

  D:\D\N\Slicer-1-build\python-install\Lib\site-packages\pip\commands\install.py:194: UserWarning: 
  Disabling all use of wheels due to the use of --build-options / --global-options / --install-options.

@jcfr
Copy link
Collaborator

jcfr commented Dec 8, 2017

Yes.

I have been working on address this, it will be fixed later today.

slicerbot pushed a commit to Slicer/SlicerGitSVNArchive that referenced this issue Dec 8, 2017
…on build dir

It also adds "UserWarning:" as an error exception.

See AIM-Harvard/SlicerRadiomics#23 (comment)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26690 3bd1e089-480b-0410-8dfb-8563597acbee
@jcfr
Copy link
Collaborator

jcfr commented Dec 9, 2017

Extension now available on all platform: http://slicer.cdash.org/index.php?project=Slicer4&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=Radiomics

After releasing Slicer 4.8.1, it will also be available with the stable release.

@jcfr jcfr closed this as completed Dec 9, 2017
jcfr added a commit to Slicer/SlicerGitSVNArchive that referenced this issue Dec 20, 2017
…on build dir

It also adds "UserWarning:" as an error exception.

See AIM-Harvard/SlicerRadiomics#23 (comment)

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-8@26781 3bd1e089-480b-0410-8dfb-8563597acbee
jcfr added a commit to jcfr/SlicerGitSVNArchive that referenced this issue Jan 18, 2018
…on build dir

It also adds "UserWarning:" as an error exception.

See AIM-Harvard/SlicerRadiomics#23 (comment)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@26690 3bd1e089-480b-0410-8dfb-8563597acbee
jcfr added a commit to Slicer/Slicer that referenced this issue Mar 13, 2020
jcfr added a commit to NA-MIC/svn.slicer.org-Slicer4 that referenced this issue Dec 22, 2022
…on build dir

It also adds "UserWarning:" as an error exception.

See AIM-Harvard/SlicerRadiomics#23 (comment)

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-8@26781 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants