Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SPBCG solver #1729

Merged
merged 7 commits into from Mar 16, 2022
Merged

remove SPBCG solver #1729

merged 7 commits into from Mar 16, 2022

Conversation

FFroehlich
Copy link
Member

remove SPBCG solver due to divergence from remaining codebase and lack of willing individuals to maintain code.

@FFroehlich FFroehlich requested a review from dweindl March 16, 2022 15:12
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1729 (400a602) into develop (88371ad) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1729      +/-   ##
===========================================
- Coverage    78.20%   77.76%   -0.44%     
===========================================
  Files           73       73              
  Lines        11471    11375      -96     
===========================================
- Hits          8971     8846     -125     
- Misses        2500     2529      +29     
Flag Coverage Δ
cpp 74.59% <0.00%> (-0.73%) ⬇️
petab 62.51% <ø> (ø)
python 68.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/newton_solver.h 33.33% <ø> (-66.67%) ⬇️
src/newton_solver.cpp 72.38% <0.00%> (-6.97%) ⬇️
src/steadystateproblem.cpp 81.69% <ø> (-1.00%) ⬇️
include/amici/vector.h 77.27% <0.00%> (-16.67%) ⬇️
src/model_ode.cpp 70.79% <0.00%> (-5.95%) ⬇️
src/sundials_matrix_wrapper.cpp 79.58% <0.00%> (-2.99%) ⬇️
src/solver_cvodes.cpp 69.23% <0.00%> (-1.88%) ⬇️
... and 3 more

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit d8d164c into develop Mar 16, 2022
@FFroehlich FFroehlich deleted the remove_SPBCG branch March 16, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants