Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model import: parallelize computation of derivatives #1740

Merged
merged 3 commits into from Mar 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test_performance.yml
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- develop
- master
- compile_without_optimization
- feature_1739_par_jac

pull_request:
branches:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
# import test model
- name: Import test model
run: |
check_time.sh petab_import python tests/performance/test.py import
AMICI_IMPORT_NPROCS=2 check_time.sh petab_import python tests/performance/test.py import

- name: "Upload artifact: CS_Signalling_ERBB_RAS_AKT_petab"
uses: actions/upload-artifact@v1
Expand Down
31 changes: 25 additions & 6 deletions python/amici/ode_export.py
Expand Up @@ -418,15 +418,27 @@ def smart_jacobian(eq: sp.MutableDenseMatrix,
:return:
jacobian of eq wrt sym_var
"""
if min(eq.shape) and min(sym_var.shape) \
and not smart_is_zero_matrix(eq) \
and not smart_is_zero_matrix(sym_var):
if (
not min(eq.shape)
or not min(sym_var.shape)
or smart_is_zero_matrix(eq)
or smart_is_zero_matrix(sym_var)
):
return sp.zeros(eq.shape[0], sym_var.shape[0])

if (n_procs := int(os.environ.get("AMICI_IMPORT_NPROCS", 1))) == 1:
# serial
return sp.Matrix([
eq[i, :].jacobian(sym_var) if eq[i, :].has(*sym_var.flat())
else [0] * sym_var.shape[0]
_jacobian_row(eq[i, :], sym_var)
for i in range(eq.shape[0])
])
return sp.zeros(eq.shape[0], sym_var.shape[0])

# parallel
from multiprocessing import Pool
with Pool(n_procs) as p:
mapped = p.starmap(_jacobian_row,
((eq[i, :], sym_var) for i in range(eq.shape[0])))
return sp.Matrix(mapped)


@log_execution_time('running smart_multiply', logger)
Expand Down Expand Up @@ -3322,3 +3334,10 @@ def _custom_pow_eval_derivative(self, s):
(self.base, sp.And(sp.Eq(self.base, 0), sp.Eq(dbase, 0))),
(part2, True)
)


def _jacobian_row(eq_i, sym_var):
"""Compute a row of a jacobian"""
if eq_i.has(*sym_var.flat()):
return eq_i.jacobian(sym_var)
return [0] * sym_var.shape[0]