Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pathlib.Path #1769

Merged
merged 4 commits into from Apr 8, 2022
Merged

Add support for pathlib.Path #1769

merged 4 commits into from Apr 8, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 7, 2022

Closes #1721

@dweindl dweindl requested a review from FFroehlich April 7, 2022 21:14
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1769 (be55852) into develop (6879ccd) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1769      +/-   ##
===========================================
- Coverage    73.62%   73.59%   -0.04%     
===========================================
  Files           71       71              
  Lines        12050    12053       +3     
===========================================
- Hits          8872     8870       -2     
- Misses        3178     3183       +5     
Flag Coverage Δ
cpp 74.98% <ø> (-0.03%) ⬇️
python 68.75% <40.00%> (-0.05%) ⬇️
sbmlsuite 86.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import.py 0.00% <0.00%> (ø)
python/amici/petab_import_pysb.py 0.00% <0.00%> (ø)
python/amici/__init__.py 90.47% <100.00%> (ø)
python/amici/ode_export.py 92.36% <100.00%> (ø)
python/amici/pysb_import.py 91.81% <100.00%> (ø)
python/amici/sbml_import.py 93.22% <100.00%> (ø)
src/sundials_matrix_wrapper.cpp 80.08% <0.00%> (-0.45%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 5e986f3 into develop Apr 8, 2022
@dweindl dweindl deleted the pathlib branch April 8, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants