Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unused parameters in simulate_petab #1816

Merged
merged 5 commits into from Jul 5, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 1, 2022

Raise a warning if parameters have been passed that do not occur in the parameter mapping and wouldn't be used anywhere.

Raise a warning if parameters have been passed that do not occur in the parameter mapping and wouldn't be used anywhere.
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1816 (9fcd870) into develop (e835f94) will decrease coverage by 0.67%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1816      +/-   ##
===========================================
- Coverage    76.11%   75.43%   -0.68%     
===========================================
  Files           74       74              
  Lines        12647    12776     +129     
===========================================
+ Hits          9626     9638      +12     
- Misses        3021     3138     +117     
Flag Coverage Δ
cpp 72.69% <ø> (-0.08%) ⬇️
petab 59.53% <87.50%> (+0.05%) ⬆️
python 68.61% <50.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/parameter_mapping.py 75.96% <87.50%> (+0.76%) ⬆️
python/amici/petab_objective.py 58.17% <0.00%> (-35.74%) ⬇️
src/amici.cpp 65.90% <0.00%> (-4.55%) ⬇️
src/exception.cpp 75.67% <0.00%> (ø)
src/solver_cvodes.cpp 70.01% <0.00%> (ø)
python/amici/gradient_check.py 97.82% <0.00%> (+11.95%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 9cb8771 into develop Jul 5, 2022
@dweindl dweindl deleted the simpetab_check_pars branch July 5, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants