Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: only try to publish docker image if secrets are set #2310

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 23, 2024

Another attempt to avoid failures on forks due to unavailable secrets. The previous check did not cover push-triggered runs.

@dweindl dweindl requested a review from a team as a code owner February 23, 2024 17:49
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (8b324bc) to head (cee7e43).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2310      +/-   ##
===========================================
- Coverage    77.78%   77.77%   -0.02%     
===========================================
  Files          318      318              
  Lines        20534    20534              
  Branches      1436     1436              
===========================================
- Hits         15973    15970       -3     
- Misses        4558     4561       +3     
  Partials         3        3              
Flag Coverage Δ
cpp 73.56% <ø> (-0.02%) ⬇️
cpp_python 34.00% <ø> (ø)
petab 36.39% <ø> (ø)
python 72.33% <ø> (-0.01%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dweindl dweindl self-assigned this Feb 23, 2024
@dweindl dweindl added this pull request to the merge queue Feb 26, 2024
Merged via the queue into AMICI-dev:develop with commit b355ab7 Feb 26, 2024
19 of 20 checks passed
@dweindl dweindl deleted the gha_secretcheck branch February 26, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants