Refactor DEExporter/DEModel/csc_matrix #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce unnecessary coupling: * `csc_matrix` as free function - removes the need for the codeprinter in DEModel * Move the codeprinter to `DEExporter` where it's actually needed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2311 +/- ##
========================================
Coverage 77.78% 77.78%
========================================
Files 318 318
Lines 20534 20535 +1
Branches 1436 1436
========================================
+ Hits 15973 15974 +1
Misses 4558 4558
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Feb 26, 2024
| # Sympy code optimizations are incompatible with PySB objects, as | ||
| # `pysb.Observable` comes with its own `.match` which overrides | ||
| # `sympy.Basic.match()`, breaking `sympy.codegen.rewriting.optimize`. | ||
| exporter._code_printer._fpoptimizer = None |
There was a problem hiding this comment.
:( sounds like this is something we want to get fixed. We could convert everything to expressions.
There was a problem hiding this comment.
Ideally there wouldn't be any PySB objects anymore at the stage of code generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce unnecessary coupling:
csc_matrixas free function - removes the need for the codeprinter inDEModelDEModeltoDEExporterwhere it's actually neededNot other changes in functionality.
Related to #2306