Refactor de_export.py, extract _codegen.model_class #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move everything related to information on C++ model functions to a separate module. Related to AMICI-dev#2306. No changes in functionality.
Move functionality for generating the ``amici::Model`` subclass code to a separate file. Related to AMICI-dev#2306
dweindl
force-pushed
the
refactor_deexport_modelclass
branch
from
bf90569
to
09d94f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2319 +/- ##
============================================
- Coverage 77.88% 36.90% -40.99%
============================================
Files 322 102 -220
Lines 20678 14642 -6036
Branches 1440 1364 -76
============================================
- Hits 16105 5403 -10702
- Misses 4570 8934 +4364
- Partials 3 305 +302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move functionality for generating the
amici::Modelsubclass code to a separate file.Related to #2306