Fix links in emails #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage 78.92% 78.92%
Complexity 151 151
=========================================
Files 35 35
Lines 522 522
Branches 20 20
=========================================
Hits 412 412
Misses 100 100
Partials 10 10
Continue to review full report at Codecov.
|
| com.ampnet.mailservice.mail.wallet-activated-path=dash/wallet | ||
| com.ampnet.mailservice.mail.manage-project-path=manage_project | ||
| com.ampnet.mailservice.mail.overview-path=overview | ||
| com.ampnet.mailservice.mail.manage-project-path=dash/project |
There was a problem hiding this comment.
This is suspicious. Why project when the "manage project" screen is here: https://staging.ampnet.io/ampnet/dash/projects/5aeda05e-1ba4-4be9-8601-deb89cf9cc24/edit?
There was a problem hiding this comment.
It is renamed to project-path, and it is used like this: dash/project + /{projectUuid}.
There is no needed to force the user to edit screen.
There was a problem hiding this comment.
dash/project route doesn't exist. dash/projects and dash/projects/:uuid do. (singular -> plural) is the issue.
There was a problem hiding this comment.
What is the difference between dash/projects/:uuid and dash/offers/:uuid? And which one to use?
There was a problem hiding this comment.
dash/projects shows all the projects (and groups) that can be managed from a project owner's perspective. (suited for project owners and group owners/managers).
dash/offers shows the list of all active projects that are available to invest in (suited for investors).
dash/offers/:uuid and dash/projects/:uuid are mirrored and show the project page for investors. The mirroring thing has a purpose.
We wanted to split responsibility for investors (offers) and project maintainers (projects).
I wanted to make it look better from the project manager perspective:
Bad navigation (pay attention to offers segment):
- Projects screen:
dash/projects - Project screen:
dash/offers/:uuid - Project edit screen
dash/projects/:uuid/edit
Better navigation:
- Projects screen:
dash/projects - Project screen:
dash/projects/:uuid - Project edit screen
dash/projects/:uuid/edit
It depends on perspective which route is semantically better.
In your case of managing a project, it is better to route to dash/projects or dash/projects/:uuid.
Does it help?
There was a problem hiding this comment.
Awesome! I will use: dash/projects + /:uuid.
No description provided.