Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpolater for grad phi in Gravity #469

Closed
WeiqunZhang opened this issue Dec 20, 2018 · 2 comments
Closed

Interpolater for grad phi in Gravity #469

WeiqunZhang opened this issue Dec 20, 2018 · 2 comments
Labels
bug 🐛 gravity

Comments

@WeiqunZhang
Copy link
Member

I think there is a bug in the interpolation of grad phi in Castro.cpp and Gravity.cpp. It uses node_bilinear_interp, but grad phi is not all nodal. AMReX currently doesn't have interpolaters for face data. I will work on that next month because FLASH asks for it.
@zingale
Copy link
Member

zingale commented Feb 9, 2019 •
edited

@WeiqunZhang , was this implemented in AMReX yet?

@zingale
Copy link
Member

zingale commented Sep 26, 2019

@WeiqunZhang ping?

This was referenced Jul 8, 2020
Closed
Merged
zingale pushed a commit that referenced this issue Jul 9, 2020
@maxpkatz
Use the new AMReX face interpolator for grad phi (#1123)
f8e8439 
This fixes #469 and fixes #1118 by ensuring that the interpolator for grad phi (used when gravity.max_solve_level is in play) is valid for nodal data.
@zingale zingale closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 gravity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zingale @WeiqunZhang