-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert center to auto prob params #1222
Conversation
Previously you could add parameters to _prob_params that were not in the Fortran namelist. No C++ version was made of these parameters. However, there is a need for even the ones not in the namelist to have a C++ version, since we may set those variables in probinit and want them later in C++. This implements that change, with the exception of parameters whose size depends on a Fortran module parameter (since we have no direct analogue of that in C++). As a demonstration, many of the wdmerger C++ problem parameters (which were manually managed as duplicates of the corresponding Fortran parameters) are converted to this new format. This will also be helpful for finishing up #1222 since we will need center in C++.
Conflicts: Source/hydro/Castro_ctu_nd.F90
The only failure was RadSuOlson which was due to a flaw in my logic in the probdata script (for the case with a non-zero number of parameters but none of which use the fortin namelist). This has been fixed so we can retest. |
That crashes because the problem doesn't call |
Rather than rely on problems to manually call probdata_init() in amrex_probinit(), this is now called by default for all setups. While this has no specific benefit at present (other than simplifying code), it becomes functionally relevant when we start adding parameters to _default_prob_params (#1222).
Conflicts: CHANGES.md
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-09-23-006/index.html |
Sedov should be fixed |
PR summary
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate