Convert center to auto prob params #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
zingale
pushed a commit
that referenced
this pull request
Sep 22, 2020
Previously you could add parameters to _prob_params that were not in the Fortran namelist. No C++ version was made of these parameters. However, there is a need for even the ones not in the namelist to have a C++ version, since we may set those variables in probinit and want them later in C++. This implements that change, with the exception of parameters whose size depends on a Fortran module parameter (since we have no direct analogue of that in C++). As a demonstration, many of the wdmerger C++ problem parameters (which were manually managed as duplicates of the corresponding Fortran parameters) are converted to this new format. This will also be helpful for finishing up #1222 since we will need center in C++.
Conflicts: Source/hydro/Castro_ctu_nd.F90
|
The only failure was RadSuOlson which was due to a flaw in my logic in the probdata script (for the case with a non-zero number of parameters but none of which use the fortin namelist). This has been fixed so we can retest. |
|
That crashes because the problem doesn't call |
5 tasks
zingale
pushed a commit
that referenced
this pull request
Sep 23, 2020
Rather than rely on problems to manually call probdata_init() in amrex_probinit(), this is now called by default for all setups. While this has no specific benefit at present (other than simplifying code), it becomes functionally relevant when we start adding parameters to _default_prob_params (#1222).
Conflicts: CHANGES.md
|
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-09-23-006/index.html |
|
Sedov should be fixed |
zingale
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate