Fix Resize Issue of Fab with the Async Arena #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was an issue with resizing Fabs using The_Async_Arena. The
issue was the previous allocation during resize might be done on a different
stream. This commit fixes the issue and makes the following patterns work.
FArrayBox tmp0(The_Async_Arena());
FArrayBox tmp1(The_Async_Arena());
FArrayBox tmp2;
for (MFIter ...) {
tmp0.resize(box,ncomp,The_Async_Arena());
tmp1.resize(box,ncomp);
tmp2.resize(box,ncomp,The_Async_Arena());
}
|
this fixes the Castro problems when we remove the Elixir's in hydro |
5 tasks
zingale
approved these changes
Dec 12, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
## Summary
Previously there was an issue with resizing Fabs using The_Async_Arena.
The issue was the previous allocation during resize might be done on a
different stream. This commit fixes the issue and makes the following
patterns work.
FArrayBox tmp0(The_Async_Arena());
FArrayBox tmp1(The_Async_Arena());
FArrayBox tmp2;
for (MFIter ...) {
tmp0.resize(box,ncomp,The_Async_Arena());
tmp1.resize(box,ncomp);
tmp2.resize(box,ncomp,The_Async_Arena());
}
## Additional background
AMReX-Astro/Castro#2677
## Checklist
The proposed changes:
- [x] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously there was an issue with resizing Fabs using The_Async_Arena. The issue was the previous allocation during resize might be done on a different stream. This commit fixes the issue and makes the following patterns work.
Additional background
AMReX-Astro/Castro#2677
Checklist
The proposed changes: