Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove elixirs in Castro_ctu_hydro #2675

Merged
merged 4 commits into from
Dec 17, 2023
Merged

remove elixirs in Castro_ctu_hydro #2675

merged 4 commits into from
Dec 17, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Dec 11, 2023

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the title remove elixirs in Source/driver/ remove elixirs in Castro_ctu_hydro Dec 11, 2023
@zingale
Copy link
Member Author

zingale commented Dec 12, 2023

this needs AMReX-Codes/amrex#3663 to work

@zingale
Copy link
Member Author

zingale commented Dec 13, 2023

gpu tests: http://groot.astro.sunysb.edu/Castro/test-suite/gpu/2023-12-12-003/index.html

@zingale zingale merged commit 27d602e into AMReX-Astro:development Dec 17, 2023
19 checks passed
@zingale zingale deleted the remove_elixir_II branch December 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz