Conduit: Fix SoA Particle #4065
Merged
+12
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the SoA particle structures for Conduit. Handle zero particles on MPI ranks without UB.
ax3l
force-pushed
the
fix-conduit-particles-soa
branch
from
7c9f095
to
6233aa5
Compare
|
@ChristosT @c-wetterer-nelson FYI on this bugfix in AMReX for Conduit/Ascent. This should affect your Catalyst2 work as well, since you pick up our WarpX data via Conduit. |
|
@ax3l looks like that fixed it! Thanks! |
atmyers
approved these changes
Aug 6, 2024
|
Thanks @ax3l for fixing and @nicolemarsaglia for testing! |
|
@ax3l thanks for fixing this! |
|
Yay! 🎉 Thank you for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the SoA particle structures for Conduit. Handle zero particles on MPI ranks without UB.
Additional background
Fix #4062
ECP-WarpX/WarpX#5087
cc @cyrush @ChristosT @c-wetterer-nelson
Checklist
The proposed changes: