Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conduit/Ascent is Broken for Pure SoA Particles #4062

Closed
ax3l opened this issue Aug 5, 2024 · 0 comments · Fixed by #4065
Closed

Conduit/Ascent is Broken for Pure SoA Particles #4062

ax3l opened this issue Aug 5, 2024 · 0 comments · Fixed by #4065
Assignees
@ax3l @atmyers
Labels
bug

Comments

@ax3l
Copy link
Member

ax3l commented Aug 5, 2024 •
edited
Loading

X-ref: ECP-WarpX/WarpX#5087 cc @cyrush @nicolemarsaglia

For pure SoA particles, we currently do not handle gracefully:

  1. zero particles on an MPI rank, provoking a memory violation
  2. use the wrong id handler instead of soa.GetIdCPUData()
@ax3l ax3l added the bug label Aug 5, 2024
@ax3l ax3l assigned ax3l and atmyers Aug 5, 2024
@ax3l ax3l changed the title Conduit/Ascent is Broken for Pure SoA Conduit/Ascent is Broken for Pure SoA Particles Aug 5, 2024
@ax3l ax3l mentioned this issue Aug 6, 2024
Merged
6 tasks
atmyers pushed a commit that referenced this issue Aug 6, 2024
@ax3l
Conduit: Fix SoA Particle (#4065)
30caf09 
## Summary

Fix the SoA particle structures for Conduit. Handle zero particles on
MPI ranks without UB.

- [ ] @nicolemarsaglia can you test this? 🙏 

## Additional background

Fix #4062
ECP-WarpX/WarpX#5087

cc @cyrush @ChristosT @c-wetterer-nelson 

## Checklist

The proposed changes:
- [x] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

@atmyers atmyers

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conduit: Fix SoA Particle ax3l/amrex
2 participants
@ax3l @atmyers