Control chemistry BoxArray - remove some avgDown #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MAGMA with relatively large mechanisms, the memory requirements prevent using grid patches bigger than 32^3. This results in a large number of boxes that deteriorates the scaling performances, especially in the linear solvers. Since PeleLMeX already utilize a specific BoxArray for the chemistry to only integrate non fine-covered boxes, this PR introduce a user-controlled parameter to specify a max grid size for this specific BA:
peleLM.max_grid_size_chem = 32
If this keyword is not provided, the usual
amr.max_grid_size
is used.Additionally, this PR remove the machinery that used to handle averaging down the reaction term and advancing fine-covered region with A+D+R in place of calling the reaction integrator. This leads to small differences on I_R (<1e-12) in fine-covered regions, that can propagate to the rest of the solution when regriding (but still < 1e-12 differences on state variables). Averaging down of RhoRT and density are also removed since those call did not affect the solution.