Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control chemistry BoxArray - remove some avgDown #125

Merged
merged 15 commits into from
Oct 6, 2022
Merged

Conversation

esclapez
Copy link
Collaborator

When using MAGMA with relatively large mechanisms, the memory requirements prevent using grid patches bigger than 32^3. This results in a large number of boxes that deteriorates the scaling performances, especially in the linear solvers. Since PeleLMeX already utilize a specific BoxArray for the chemistry to only integrate non fine-covered boxes, this PR introduce a user-controlled parameter to specify a max grid size for this specific BA:
peleLM.max_grid_size_chem = 32
If this keyword is not provided, the usual amr.max_grid_size is used.
Additionally, this PR remove the machinery that used to handle averaging down the reaction term and advancing fine-covered region with A+D+R in place of calling the reaction integrator. This leads to small differences on I_R (<1e-12) in fine-covered regions, that can propagate to the rest of the solution when regriding (but still < 1e-12 differences on state variables). Averaging down of RhoRT and density are also removed since those call did not affect the solution.

@nickwimer nickwimer merged commit dce5b1b into development Oct 6, 2022
@nickwimer nickwimer deleted the maxGridChem branch October 6, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants