Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Control max velocity default value fix #233

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

olivecha
Copy link
Contributor

@olivecha olivecha commented Aug 21, 2023

The default value for m_ctrl_velMax was set to -1.0 in PeleLM.H

The updated velocity in PeleLMFlowControler.cpp is not limited by the maximum velocity parameter if the parameter value is less than zero.

This result in the active_control.velMax input file parameter being truly optional (see issue #232).

Active control was able to converge without setting the active_control.velMax parameter:

image

@baperry2
Copy link
Collaborator

Thanks for doing this!

Can you also modify the docs here to reflect the slightly updated behavior?
https://github.com/AMReX-Combustion/PeleLMeX/blob/62b496ca0abf7bad0ef971cb53fde6eb0226a781/Docs/source/manual/LMeXControls.rst?plain=1#L387C11-L387C11

Closes #232

@baperry2 baperry2 self-requested a review August 21, 2023 22:08
Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, this should be good assuming all the tests pass.

@baperry2 baperry2 linked an issue Aug 21, 2023 that may be closed by this pull request
@baperry2 baperry2 merged commit fbbe5a9 into AMReX-Combustion:development Aug 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value of active_control.velMax
2 participants