Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PelePhysics. Fix some unused variables. #261

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Update PelePhysics. Fix some unused variables. #261

merged 4 commits into from
Sep 20, 2023

Conversation

jrood-nrel
Copy link
Contributor

No description provided.

@jrood-nrel jrood-nrel enabled auto-merge (squash) September 20, 2023 18:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2023
View reviewed changes
Exec/RegTests/EnclosedInjection/pelelm_prob.H
Comment on lines +30 to +40
/*
AMREX_D_TERM(const amrex::Real x = prob_lo[0] + (i + 0.5) * dx[0];
, const amrex::Real y = prob_lo[1] + (j + 0.5) * dx[1];
, const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2];);

AMREX_D_TERM(const amrex::Real Lx = prob_hi[0] - prob_lo[0];
, const amrex::Real Ly = prob_hi[1] - prob_lo[1];
, const amrex::Real Lz = prob_hi[2] - prob_lo[2]);

constexpr amrex::Real Pi = 3.14159265358979323846264338327950288;
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/EnclosedInjection/pelelm_prob.H
Comment on lines +27 to +29
// const amrex::Real* prob_lo = geomdata.ProbLo();
// const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* dx = geomdata.CellSize();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/TaylorGreen/pelelm_prob.H
Comment on lines +34 to +38
/*
AMREX_D_TERM(const amrex::Real Lx = prob_hi[0] - prob_lo[0];
, const amrex::Real Ly = prob_hi[1] - prob_lo[1];
, const amrex::Real Lz = prob_hi[2] - prob_lo[2]);
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/EnclosedFlame/pelelm_prob.H
@@ -41,7 +41,7 @@
, const amrex::Real yc = prob_lo[1] + 0.5 * Ly;
, const amrex::Real zc = prob_lo[2] + 0.5 * Lz;);

constexpr amrex::Real Pi = 3.14159265358979323846264338327950288;
// constexpr amrex::Real Pi = 3.14159265358979323846264338327950288;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/TurbInflow/pelelm_prob.H
Comment on lines +38 to +42
/*
AMREX_D_TERM(const amrex::Real x_c = prob_lo[0] + 0.5 * Lx;
, const amrex::Real y_c = prob_lo[1] + 0.5 * Ly;
, const amrex::Real z_c = prob_lo[2] + 0.5 * Lz);
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/TurbInflow/pelelm_prob.H
Comment on lines +35 to +37
/* AMREX_D_TERM(const amrex::Real Lx = prob_hi[0] - prob_lo[0];
, const amrex::Real Ly = prob_hi[1] - prob_lo[1];
, const amrex::Real Lz = prob_hi[2] - prob_lo[2]);*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/TurbInflow/pelelm_prob.H
Comment on lines +30 to +34
/*
AMREX_D_TERM(const amrex::Real x = prob_lo[0] + (i + 0.5) * dx[0];
, const amrex::Real y = prob_lo[1] + (j + 0.5) * dx[1];
, const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2];);
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/TurbInflow/pelelm_prob.H
Comment on lines +27 to +29
// const amrex::Real* prob_lo = geomdata.ProbLo();
// const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* dx = geomdata.CellSize();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/PeriodicCases/pelelm_prob.H
Comment on lines +33 to +40
/*
AMREX_D_TERM(const amrex::Real Lx = prob_hi[0] - prob_lo[0];
, const amrex::Real Ly = prob_hi[1] - prob_lo[1];
, const amrex::Real Lz = prob_hi[2] - prob_lo[2]);
AMREX_D_TERM(const amrex::Real x_c = prob_lo[0] + 0.5 * Lx;
, const amrex::Real y_c = prob_lo[1] + 0.5 * Ly;
, const amrex::Real z_c = prob_lo[2] + 0.5 * Lz);
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Exec/RegTests/PeriodicCases/pelelm_prob.H
amrex::GeometryData const& geomdata,
ProbParm const& prob_parm,
pele::physics::PMF::PmfData::DataContainer const* /*pmf_data*/)
{
const amrex::Real* prob_lo = geomdata.ProbLo();
const amrex::Real* prob_hi = geomdata.ProbHi();
// const amrex::Real* prob_hi = geomdata.ProbHi();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@jrood-nrel jrood-nrel merged commit 940eb5d into development Sep 20, 2023
16 of 18 checks passed
@jrood-nrel jrood-nrel deleted the jrood/unused branch September 20, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrood-nrel @marchdf