Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A series a small fixes and changes #73

Merged
merged 7 commits into from
Apr 15, 2022
Merged

A series a small fixes and changes #73

merged 7 commits into from
Apr 15, 2022

Conversation

esclapez
Copy link
Collaborator

@esclapez esclapez commented Apr 15, 2022

  • add a function to fix the velocity in small cells (unused at this point)
  • add lightweight memory checks throughout the algorithm (peleLM.memory_checks = 1) and add a call to AMReX profiler
  • fix detection of closed chamber -> can have inflow
  • fix error when using peleLM.incompressible = 1
  • use typical values for the covered cells and switch to using min/max average to define those
  • fix typo on setCovered in Eos

@esclapez esclapez merged commit 9faf738 into development Apr 15, 2022
@esclapez esclapez deleted the smallFixes branch April 15, 2022 06:55
bssoriano pushed a commit that referenced this pull request Dec 4, 2022
* Use TypVals in covered cells and add a correctVel_small_cell function (not used at this point).

* Fix typo on EB test.

* Update debug plot of InitSol.

* Domain can have inflow and still be closed.

* Make typical value as averaged of min/max and for species Ys
instead of rhoYs

* Fix temporal when running incompressible.

* Add a lighweight check of the HWM MFs memory usage and a call to
AMReX's mem profiler at the begining of the step if compiled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant