Enable isothermal EB specification #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Source/PeleLMEB.cpp
not convinced it works better.
|
Conflicts: Source/PeleLMDiffusion.cpp Source/PeleLMUtils.cpp Source/PeleLM_K.H
Conflicts: Source/PeleLMDiffusion.cpp Source/PeleLMEB.cpp Source/PeleLMUtils.cpp Source/PeleLM_K.H
…soT_EB Conflicts: Source/PeleLMDiffusion.cpp
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baperry2
approved these changes
Mar 31, 2023
Docs/source/manual/LMeXControls.rst
Outdated
| @@ -231,14 +264,14 @@ The `eb2.small_volfrac` controls volume fraction that are deemed too small and e | |||
| This operation is done iteratively and the maximum number of iteration is prescribed by `eb2.maxiter`. | |||
| For most applications, a single AMReX object is insufficient to represent the geometry. AMReX enable to combine | |||
| objects using constructive solid geometry (CSG) in order to create complex geometry. It is up to the user to define | |||
| the combination of basic elements leading to its desired geometry. To switch to a user-defined EB definition, one | |||
| the combination of basic elements leading to his desired geometry. To switch to a user-defined EB definition, one | |||
There was a problem hiding this comment.
Change "the user" to "users" and "his" to "their"
| xcell[2] + ebfc_z(i,j,k) * dx[2])}; | ||
| amrex::Real ebflagtype = 0.0; | ||
| setEBType(xface, ebflagtype, geomdata, *lprobparm); | ||
| ebdiff(i,j,k) = diff_cc(i,j,k) * ebflagtype; |
There was a problem hiding this comment.
Just a note that if running with an LES model this will only get the molecular component of the thermal diffusivity because the turbulent component is added when moving from cc to fc. I believe this behavior is the same for how the no slip condition on EBs is presently implemented, and is fine. If using WALE and enough resolution at the boundaries the turbulent part should go to 0 anyway, and if not then we'd want to add a wall model.
There was a problem hiding this comment.
Good catch. It's probably worth adding a note in the doc for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, activating isothermal EB with
peleLM.isothermal_EB = 1set the entire EB as Dirichlet, the value of which then needs to be specified by thesetEBStatefunction, added to pelelm_prob.H.See Exec/Regtests/EB_FlowPastCylinder for an implementation example.