Deploy action #602
Merged
Deploy action #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewbonney happy to remove utilities/deploy but before I do is there any value in keeping docker-compose.yml? And if so where would people most likely want to see it located? |
|
At present, the only value is the fact the port mappings are pre-defined so you don't need to know how to set them up at the command line. In the long run it could be made more useful by adding things like an auth server. It could possibly be left in that directory for now, but if so is the copy in .deploy necessary? |
|
@andrewbonney I've removed utilities/deploy but left .deploy/docker-compose.yml for now |
andrewbonney
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to GitHub Actions for building and uploading Docker container. Follows same pattern used for .render and .lint.