-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for version display in Docker #789
Conversation
…for commit and branches
Fix version display in docker image and add branch tags for docker image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent.
I know it was there before, but wondering what does branch: deploy-action mean?
Ah, @peterbrightwell says we can remove that, it's just a remnant from testing #602 before it was merged.
If the branch list includes both master and main, did the check for != master ought to be ! is_default_branch ?
Also should we put the 'publish-*'
wildcard in the branch list too, same as we use to configure publishing to specs.amwa.tv?
The template is_default_branch refuses to work as part of any expression. After experimenting with things like I can add in publish-* as a wildcard, but perhaps we should think a bit more about how we would use that tag. Would it be the one used for the NMOS Testbed, for example, or other maintained deployments? We can go back to this idea later once we start seeing what makes sense for a "published" docker image. |
Ah, it's currently tricky, see response from the author at docker/metadata-action#247 |
Looks like it's now an enhancement that might be picked up to be able to cleanly use is_default_branch to enable tags on non-default. Probably for consistency I'd prefer just to use something like the following and avoid is_default_branch entirely since it generates questions:
|
Ok, that's fine, then I'd change the comment about default to master and/or remove main from the list of branches as well as deploy-action. Since we don't use |
Made the changes but left in |
changes from PR review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes :