Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS Review] Sort imports re-factor #80

Closed
mhubii opened this issue Jan 23, 2024 · 2 comments
Closed

[JOSS Review] Sort imports re-factor #80

mhubii opened this issue Jan 23, 2024 · 2 comments
Assignees
@a-niem
Labels
enhancement New feature or request

Comments

@mhubii
Copy link

mhubii commented Jan 23, 2024 •
edited

Hope this is not too OCD, but consider sorting imports, using e.g. https://pycqa.github.io/isort/, which has e.g. a visual studio code plugin https://marketplace.visualstudio.com/items?itemName=ms-python.isort

See e.g. this file

ParticleTracking/RodTracker/src/RodTracker/ui/reconstruction.py

Line 18 in c946dea

import os

@mhubii mhubii added the enhancement New feature or request label Jan 23, 2024
@a-niem a-niem self-assigned this Jan 25, 2024
a-niem added a commit that referenced this issue Jan 30, 2024
@a-niem
Sort imports in RodTracker
2719eb7 
Sort the imports (see #80) and apply formatting with black in the RodTracker files.
a-niem added a commit that referenced this issue Jan 30, 2024
@a-niem
Sort imports in ParticleDetection
3ac99fb 
Sort the imports (see #80) and apply formatting with black in the ParticleDetection files.
a-niem added a commit that referenced this issue Jan 30, 2024
@a-niem
Adjust workflows
ee9ddf3 
Replace previous linting workflow with updated version, that uses isort and black. (see #80)
@mhubii mhubii changed the title [JOSS] Sort imports re-factor [JOSS Review] Sort imports re-factor Feb 3, 2024
@mhubii
Copy link
Author

mhubii commented Feb 3, 2024

openjournals/joss-reviews#5986

@a-niem
Copy link
Collaborator

a-niem commented Apr 30, 2024

Imports have been sorted, and a workflow has been updated to verify adherence in new commits.

@a-niem a-niem closed this as completed Apr 30, 2024
@a-niem a-niem mentioned this issue May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-niem a-niem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhubii @a-niem