Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Build from an R base image #384

Merged
merged 4 commits into from
May 12, 2023
Merged

WIP: Build from an R base image #384

merged 4 commits into from
May 12, 2023

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented May 11, 2023

Replaces the old Ubuntu docker file with one based on the rocker project image. This has R pre-installed and avoids having to deal with installing custom keys. It makes it easier to get a specific R version and have some dependencies (eg, devtools) pre-installed.

This is a WIP, it builds with minimal dependencies

@cookpa
Copy link
Member Author

cookpa commented May 11, 2023

@ntustison @stnava is there an updated list of recommended dependencies for full functionality? The list here

https://github.com/ANTsX/ANTsR/wiki/ANTsR-Dependencies-for-(close-to)-full-functionality

is from a couple of years ago. R CMD INSTALL doesn't install most dependencies, but I can install in the dockerfile via install.packages.

devtools tries to install all dependencies from the DESCRIPTION file, but I can't get devtools install to work (#377)

@ntustison
Copy link
Member

That's a good question, @cookpa . Perhaps @stnava has more concrete knowledge (I certainly don't) but I'm guessing we might have to figure it out for the current set-up.

@stnava
Copy link
Member

stnava commented May 11, 2023 via email

@cookpa
Copy link
Member Author

cookpa commented May 12, 2023

Thanks @stnava the remotes method works. I was trying to do something similar with pak but my mistake was not calling the "local" version.

BTW, pak also has local_system_requirements which will print out an apt command to install system dependencies. Quite useful on certain systems.

@cookpa
Copy link
Member Author

cookpa commented May 12, 2023

ENH: Update docker file

Multiple improvements:

  • Use rocker base image with R pre-installed, saves time and effort dealing with manual install
  • Follow Dockerfile convention for placement of file, uses local source to build
  • Switch to R CMD INSTALL, because devtools install is not working on recent versions

@cookpa cookpa merged commit d253feb into master May 12, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants