Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port grid_map_costmap_2d to ros2 #240

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

naiveHobo
Copy link

Signed-off-by: Sarthak Mittal sarthakmittal2608@gmail.com

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
@naiveHobo
Copy link
Author

@SteveMacenski @Marwan99 need to add nav2_costmap_2d to pass Circle build but I'm guessing the grid_map ros2 branch is targeting foxy

@Marwan99 Marwan99 mentioned this pull request Jun 24, 2020
@Marwan99
Copy link

How about using the rosplanning/navigation2 docker image as a temporary solution? Just until navigation2 gets added to foxy.

@SteveMacenski
Copy link

I think the best answer is to add a tools/ros2_dependencies.repos file that contains the vcs address for map server so its built in the same workspace (isolate / remove all other packages from nav2 that aren't needed for map server)

Copy link

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything to mention. Is there anything you want to highlight that you had to change by hand that might be worth specifically having me check?

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
…dencies

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
@naiveHobo
Copy link
Author

I don't see anything to mention. Is there anything you want to highlight that you had to change by hand that might be worth specifically having me check?

I don't think anything needs to be looked over too much. There was a rostest which needed some work since I had to convert it to a normal gtest, it barely involved any launch stuff. Otherwise everything is pretty standard.

I need some help with the Circle CI config though, there are a couple of errors I can't figure out. Would be great if you could have a look.

@SteveMacenski
Copy link

You didn't install the dependencies with rosdep for the underlay workspace.

@naiveHobo naiveHobo force-pushed the costmap-port branch 3 times, most recently from e3af928 to a849caa Compare June 24, 2020 20:28
@SteveMacenski
Copy link

SteveMacenski commented Jun 24, 2020

Definitely should work now :)

All of my commits named that never work now :-) * force push * you never saw it...

@naiveHobo
Copy link
Author

Haha, okay didn't work 😆 I'm not sure where it's going wrong.

@SteveMacenski
Copy link

try the -r flag

@Marwan99
Copy link

Does the UNDERLAY_WS need to be sourced before running rosdep in the OVERLAY_WS?

@SteveMacenski
Copy link

Yes, that is a good catch

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
@naiveHobo
Copy link
Author

@SteveMacenski @maximilianwulf ready to merge!

@SteveMacenski SteveMacenski merged commit a04f121 into ANYbotics:ros2 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants