[BUGFIX] Fetch all fe_user fields in findEntitiesWithIpAuthentication #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fe_users fields fetched in findEntitiesWithIpAuthentication are used in the authentication process, e.g. to determine user groups. If only uid and pid is fetched, the authentication service doesn't consider the user as authenticated even if a user session is generated. So the user is only correctly authenticated in the next request, e.g. after a redirect.
|
Thanks @lorenzulrich could you perhaps check the tests? |
|
I can confirm the issue. The patch works in our environment. See also #60 |
|
As the tests aren't green. I would have to check manually before I can merge. Looks good to me though. I'm on vacation, 2 weeks from tomorrow. So I will see if someone else could have a look at it. and release a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fe_users fields fetched in findEntitiesWithIpAuthentication are used in the authentication process, e.g. to determine user groups. If only uid and pid is fetched, the authentication service doesn't consider the user as authenticated even if a user session is generated. So the user is only correctly authenticated in the next request, e.g. after a redirect.