Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCA Config Refactoring + CIRD Support #4

Closed
wants to merge 1 commit into from
Closed

TCA Config Refactoring + CIRD Support #4

wants to merge 1 commit into from

Conversation

aWuttig
Copy link
Contributor

@aWuttig aWuttig commented Jul 2, 2015

  • moves Entry TCA configuration into single file
  • adds CIDRUtility and cidr_match function to check if client IP if within subnet of configured excluded IP Subnet (CIDR Notation!)

@aWuttig
* moves Entry TCA configuration into single file
302d915 
* adds CIDRUtility and cidr_match function to check if client IP if within subnet of configured excluded IP Subnet (CIDR Notation!)
@vdespa
Copy link

vdespa commented Jul 3, 2015

Thanks for the PR, we will look into it as soon as we can. Please try next time to submit different PR for each bug / feature it tries to fix. It makes it easier to review and merge.

@vdespa
Copy link

vdespa commented Jul 8, 2015

We need to make some code style changes and other tests, so we temporary moved your changed to a branch. We will merge it soon. Thanks.

@vdespa vdespa closed this Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aWuttig @vdespa