Permalink
Browse files

Remove "hl=" parameter from incognito-mode GWS searches.

It prevents GWS from honoring Accept-language: headers, and can result
in degraded search result quality.

Bug: 5777487
Change-Id: Ifee726bc0b3e79be628d288606777969e72c11a0
  • Loading branch information...
1 parent f7e65c8 commit e5ce1bc4792003844b2ad60fbe2078f2ab8e1ebe Victoria Lease committed Mar 29, 2012
Showing with 4 additions and 4 deletions.
  1. +2 −2 res/values/all_search_engines.xml
  2. +2 −2 tools/get_search_engines.py
@@ -208,9 +208,9 @@ http://www.opensearch.org/Specifications/OpenSearch/1.1/Draft_4#OpenSearch_1.1_p
<item>Google</item>
<item>google.com</item>
<item>http://www.google.com/favicon.ico</item>
- <item>http://www.google.com/search?hl={language}&amp;ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}</item>
+ <item>http://www.google.com/search?ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}</item>
<item>UTF-8</item>
- <item>http://www.google.com/complete/search?hl={language}&amp;client=android&amp;q={searchTerms}</item>
+ <item>http://www.google.com/complete/search?client=android&amp;q={searchTerms}</item>
</string-array>
<string-array name="bing_en_NZ" translatable="false">
<item>Bing</item>
@@ -39,9 +39,9 @@
google_data = ["google", "Google", "google.com",
"http://www.google.com/favicon.ico",
- "http://www.google.com/search?hl={language}&amp;ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}",
+ "http://www.google.com/search?ie={inputEncoding}&amp;source=android-browser&amp;q={searchTerms}",
"UTF-8",
- "http://www.google.com/complete/search?hl={language}&amp;client=android&amp;q={searchTerms}"]
+ "http://www.google.com/complete/search?client=android&amp;q={searchTerms}"]
class SearchEngineManager(object):
"""Manages list of search engines and creates locale specific lists.

0 comments on commit e5ce1bc

Please sign in to comment.