Add a NOTE to clarify the 'mdcv' box #141
Conversation
wantehchang
force-pushed
the
issue-13-add-note-on-mdcv
branch
from
28bc839
to
e037755
Compare
|
Please add an entry to the change log as well |
In "their values SHALL match", change the word "match" to "equal (except for precision issues, see note below)". Exchange METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV so that they correspond to mdcv and clli in the right order. Fix AOMediaCodec#138.
wantehchang
force-pushed
the
issue-13-add-note-on-mdcv
branch
from
e037755
to
3e2fd6b
Compare
index.bs
Outdated
| @@ -646,3 +648,4 @@ If any character that is not '.', digits, part of the AV1 4CC, or a tier value i | |||
|
|
|||
| Changes since v1.2.0 release {#changelist} | |||
| ========================================== | |||
| - <a href="https://github.com/AOMediaCodec/av1-isobmff/pull/141"> Add a NOTE to clarify the mdcv box.</a> | |||
There was a problem hiding this comment.
I wanted to single-quote mdcv here, i.e., 'mdcv'. But the single quotes make the link generated by Bikeshed end at the word 'mdcv'. Do you know how to get around this?
There was a problem hiding this comment.
I think we have to add something like:
Markup Shorthands: css no
There was a problem hiding this comment.
I don't know what that Markup Shorthands: css no does, but it solves the problem. I will write a separate pull request to add it.
| @@ -360,10 +360,12 @@ The presentation times of AV1 samples are given by the ISOBMFF structures. <asse | |||
|
|
|||
| <assert>The CleanApertureBox 'clap' SHOULD not be present.</assert> | |||
|
|
|||
| <assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL match the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV, if present (in the configOBUs or in the samples)</assert>. | |||
| <assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL equal (except for precision issues, see the second note below) the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_MDCV and METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples)</assert>. | |||
There was a problem hiding this comment.
Note that I exchanged METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV here, so that they correspond to 'mdcv' and 'clli' in the right order.
This requires adding "Markup Shorthands: css no" to the metadata at the top of this file.
The field names in 'mdcv' and METADATA_TYPE_HDR_MDCV are not the same.
|
I messed up this pull request in my fork of the repo, so I replaced this with a new pull request: #156. Sorry about the inconvenience. |
In "their values SHALL match", change the word "match" to
"equal (except for precision issues, see note below)".
Exchange METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV so that they
correspond to mdcv and clli in the right order.
Fix #138.
Preview | Diff