Add a NOTE to clarify the 'mdcv' box #156
Conversation
wantehchang
force-pushed
the
issue-138-add-note-on-mdcv
branch
from
e2892e7
to
97fdc16
Compare
index.bs
Outdated
| @@ -357,10 +357,12 @@ The presentation times of AV1 samples are given by the ISOBMFF structures. <asse | |||
|
|
|||
| <assert>The sample entry SHOULD contain a 'colr' box with a colour_type set to 'nclx'</assert>. <assert>If present, the values of colour_primaries, transfer_characteristics, and matrix_coefficients SHALL match the values given in the [=Sequence Header OBU=] (in the configOBUs field or in the associated samples) if the color_description_present_flag is set to 1</assert>. Similarly, <assert>the full_range_flag in the 'colr' box SHALL match the color_range flag in the [=Sequence Header OBU=]</assert>. <assert>When configOBUs does not contain a [=Sequence Header OBU=], this box with colour_type set to 'nclx' SHALL be present.</assert> | |||
|
|
|||
| <assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL match the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV, if present (in the configOBUs or in the samples)</assert>. | |||
| <assert>For sample entries corresponding to HDR content, the MasteringDisplayColourVolumeBox 'mdcv' and ContentLightLevelBox 'clli' SHOULD be present</assert>, and <assert>their values SHALL equal (except for different binary representations and precision issues, see the second note below) the values contained in the [=Metadata OBUs=] of type METADATA_TYPE_HDR_MDCV and METADATA_TYPE_HDR_CLL, if present (in the configOBUs or in the samples)</assert>. | |||
There was a problem hiding this comment.
Cyril: Compared with #141 (which you reviewed), this PR changed the following:
equal (except for precision issues, see the second note below)
to:
equal (except for different binary representations and precision issues, see the second note below)
change it to:
|
Split the requirements on 'clli' and 'mdcv' into separate list items so that we can state the more complicated requirements that only apply to 'mdcv'. Fix AOMediaCodec#138.
wantehchang
force-pushed
the
issue-138-add-note-on-mdcv
branch
from
97fdc16
to
1e10cdb
Compare
|
Cyril: I made the changes you suggested. Please review. I made minor edits to your suggestion, on capitalization, fixing an error, and removing extra spaces at the end of sentences. |
Co-authored-by: Cyril Concolato <cconcolato@netflix.com>
In "their values SHALL match", change the word "match" to "equal (except for different binary representations and precision issues, see the second note below)".
Exchange METADATA_TYPE_HDR_CLL and METADATA_TYPE_HDR_MDCV so that they correspond to mdcv and clli in the right order.
Fix #138.
Preview | Diff