New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rav1e.cmd and docker/build.sh to use rav1e 0.4 #469
Conversation
Currently the CI is stuck on the following error:
I'm going to need a bit of help here, @joedrago can you make anything of it? @lu-zero Could you confirm if rav1e.cmd now installs the c-compatible rav1e library correctly? |
which version of cargo-c are you using ? |
|
you may include |
Your change to |
If you want rav1e 0.4, please just change the version branches and leave the call to cbindgen alone. |
Thanks for the reply, I tried that in the first commit of this PR, but unfortunately that run also fails. |
The current cargo-c introduced {pkg}-uninstalled.pc to address this, but looks like it needs a fix, I'll look at it during the weekend. |
Switches both rav1e.cmd and docker/build.sh to update from the rav1e 0.3 maintenance branch to the 0.4 maintenance branch
rav1e switched from cbindgen to cargo-c some time ago. With 0.4 the old method broke, so this commit replaces it with the new one. See: https://github.com/xiph/rav1e#building-the-c-api
Something I missed was that rav1e got stuck on this error: Which is probably a GitHub Actions problem. I will see if I can modify it to run with sudo privileges. |
Here is a similar issue: rust-lang/cargo#6757 |
Succeeded by #476. |
Switches both rav1e.cmd and docker/build.sh to update from the rav1e 0.3 maintenance branch to the 0.4 maintenance branch.