Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rav1e.cmd and docker/build.sh to use rav1e 0.4 #469

Closed
wants to merge 5 commits into from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jan 13, 2021

Switches both rav1e.cmd and docker/build.sh to update from the rav1e 0.3 maintenance branch to the 0.4 maintenance branch.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 13, 2021

Currently the CI is stuck on the following error:

/home/runner/work/libavif/libavif/src/codec_rav1e.c:6:10: fatal error: rav1e/rav1e.h: No such file or directory
    6 | #include "rav1e/rav1e.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/avif.dir/build.make:277: CMakeFiles/avif.dir/src/codec_rav1e.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:138: CMakeFiles/avif.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
Error: Process completed with exit code 2.

I'm going to need a bit of help here, @joedrago can you make anything of it?

@lu-zero Could you confirm if rav1e.cmd now installs the c-compatible rav1e library correctly?

@lu-zero
Copy link
Contributor

lu-zero commented Jan 13, 2021

which version of cargo-c are you using ?

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 13, 2021

cargo-c v0.7.0+cargo-0.49 currently

@lu-zero
Copy link
Contributor

lu-zero commented Jan 13, 2021

you may include rav1e.h directly if pkg-config --cflags provides -I{includedir}/rav1e

@joedrago
Copy link
Collaborator

Your change to rav1e.cmd breaks the intent of the script. The goal of that script is to create a static, local build of the library, not install it into the system, and then require that the system has it available.

@joedrago
Copy link
Collaborator

If you want rav1e 0.4, please just change the version branches and leave the call to cbindgen alone.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 14, 2021

Thanks for the reply, I tried that in the first commit of this PR, but unfortunately that run also fails.
libavif: compiled rav1e library is missing (in ext/rav1e/target/release),

@lu-zero
Copy link
Contributor

lu-zero commented Jan 14, 2021

The current cargo-c introduced {pkg}-uninstalled.pc to address this, but looks like it needs a fix, I'll look at it during the weekend.

Switches both rav1e.cmd and docker/build.sh to update from the rav1e 0.3 maintenance branch to the 0.4 maintenance branch
rav1e switched from cbindgen to cargo-c some time ago. With 0.4 the old method broke, so this commit replaces it with the new one.

See: https://github.com/xiph/rav1e#building-the-c-api
@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 16, 2021

Something I missed was that rav1e got stuck on this error: Error: CliError { error: Some(Permission denied (os error 13)), exit_code: 101 }

Which is probably a GitHub Actions problem. I will see if I can modify it to run with sudo privileges.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 16, 2021

Here is a similar issue: rust-lang/cargo#6757

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 18, 2021

Succeeded by #476.

@EwoutH EwoutH closed this Jan 18, 2021
@EwoutH EwoutH mentioned this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants