-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement Dynamic Theming for User-Selected App Color #282
[FEATURE] Implement Dynamic Theming for User-Selected App Color #282
Conversation
please review @chandansgowda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to put the theme controller in each screen and controller? There should be cleaner alternatives for this.
…adient creation logic within the controller
…7/Resonate into Feature/Dynamic-Theming
Thanks for the feedback. I've corrected the redundancy by using Get.find() to retrieve the theme controller instance, simplifying the code. in the future, I'll ensure to follow cleaner alternatives like this. |
there's any other problem? @chandansgowda |
I've solved the conflict @chandansgowda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job @AyaNady17
Description
This pull request introduces a dynamic theming feature that allows users to personalize the app's color scheme according to their preferences.
Fixes #281
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tested manually
video5980830766718784570.mp4
Checklist:
Maintainer Checklist