Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement Dynamic Theming for User-Selected App Color #282

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

AyaNady17
Copy link
Contributor

Description

This pull request introduces a dynamic theming feature that allows users to personalize the app's color scheme according to their preferences.
Fixes #281

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

tested manually

video5980830766718784570.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@AyaNady17
Copy link
Contributor Author

please review @chandansgowda

Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to put the theme controller in each screen and controller? There should be cleaner alternatives for this.

@AyaNady17
Copy link
Contributor Author

Thanks for the feedback. I've corrected the redundancy by using Get.find() to retrieve the theme controller instance, simplifying the code. in the future, I'll ensure to follow cleaner alternatives like this.
@chandansgowda

@AyaNady17
Copy link
Contributor Author

there's any other problem? @chandansgowda

@AyaNady17
Copy link
Contributor Author

I've solved the conflict @chandansgowda

Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @AyaNady17

@chandansgowda chandansgowda merged commit 73de227 into AOSSIE-Org:master Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Implement Dynamic Theming with User-Selected App Color
2 participants