Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textfield tag error #308

Closed
wants to merge 1 commit into from

Conversation

amanraval76593
Copy link
Contributor

@amanraval76593 amanraval76593 commented Mar 21, 2024

Description

This pull request addresses issue #307 .
This PR solves the issue with textfield_tags where error "String' has no instance named 'isValidTag" was thrown after a tag was entered in the textfield.

Changes:-
Defines an inline function validateTag() within the scope of the validator.
Encapsulates the validation logic within this function.
Provides better encapsulation and organization of validation logic, enhancing readability and maintainability.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test manually on physical device.
Before:
WhatsApp Image 2024-03-21 at 11 42 56_fb6d87fc
After
after

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@amanraval76593 amanraval76593 changed the title Fix textfield tag error Fix textfield tag error #307 Mar 21, 2024
@amanraval76593 amanraval76593 changed the title Fix textfield tag error #307 Fix textfield tag error Mar 21, 2024
@amanraval76593 amanraval76593 deleted the tada branch March 21, 2024 14:39
@amanraval76593 amanraval76593 mentioned this pull request Mar 21, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant