Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tag controller error #311

Closed

Conversation

amanraval76593
Copy link
Contributor

@amanraval76593 amanraval76593 commented Mar 23, 2024

Description

Fixes a bug where the TextfieldTagsController was not disposed properly, leading to resource leakage. This issue occurred when navigating away from screens that used the TextfieldTagsController without properly disposing of it.

Change:
Implemented a solution by adding a new function, resetTagController(), which disposes of the previously created TextfieldTagsController instance and creates a new one before navigating to the Create Room page.

Fixes #310

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually on the physical device.

Before:-

first.mp4

After:-

second.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@amanraval76593
Copy link
Contributor Author

@chandansgowda please review the changes

@Aarush-Acharya
Copy link
Contributor

Good Work @amanraval76593 🚀

This is good to merge will merge after the previously scheduled PR's are merged

@Aarush-Acharya Aarush-Acharya added the attended This PR was attended by a Reviewer label May 10, 2024
@vrundraval24 vrundraval24 added RMC Remove Merge Conflicts, remove the merge conflicts caused by the previous merges and removed IMS labels May 23, 2024
@vrundraval24
Copy link
Contributor

Hey, @amanraval76593 this branch has merge conflicts due to the merging of previously scheduled branches. Please resolve the merge conflicts. We will wait for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attended This PR was attended by a Reviewer awaitIntra RMC Remove Merge Conflicts, remove the merge conflicts caused by the previous merges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: You have already register a tag controller
3 participants