Fix CI tests #294
Fix CI tests #294
Conversation
Blank binary file was not getting serialized as { type: "Buffer", data: [] }
because read(file) was returning a string instead of Buffer.
Webpack 4 cannot parse module containing optional chaining operator. See https://stackoverflow.com/questions/59972341/how-to-make-webpack-accept-optional-chaining-without-babel
Recent versions of node upgraded to OpenSSL 3.0, which deprecated some older crypto hashing algorithms including md4. Webpack 4 hard codes the use of md4 ins some places, so we have to set this flag until we can upgrade Webpack.
Browser tests were failing as polyfill.js was loading a node package in a browser context.
This was when the --openssl-legacy-provider option was introduced. Prior versions of node do not recognize this option.
Browser tests are failing in the CI environment with: chokidar@3: Error: Cannot find module 'chokidar' Don't know why but this thread might be relevant: facebook/create-react-app#10811
|
thanks for this! nearly there, do you know whats up with ubuntu browser tests? |
|
It's failing because it can't launch Edge. To be honest I was hoping there would be something different about the Sauce Labs configuration in this repo than my fork that would make this work. Will need to investigate further. But maybe we don't need it for Edge anyway as it's included in the runner image? |
|
Anything we can do to get away from SauceLabs is a good thing IMO. It's been a nightmare trying to keep it happy. |
|
Ok that's good to know. These commits should now pass. https://github.com/criteria-labs/json-schema-ref-parser/actions/runs/3888908655 I got rid of Sauce Labs and browsers are now just tested on their "home" platform, i.e. Edge on windows, Safari on macOS. Though there is no runner for macos-latest because the karma launcher for Safari doesn't work (it hasn't been updated in 9 years). So there are no Safari tests at all. |
Pull Request Test Coverage Report for Build 3889025475
💛 - Coveralls |
|
This is breaking most apps that rely on Node 16:
|
|
We also had our app breaking without warning due to this. I feel like this should have been released as a new major version. Changing the minimum Node version is a breaking change after all. |
| @@ -43,7 +43,7 @@ | |||
| "fs": false | |||
| }, | |||
| "engines": { | |||
| "node": ">= 14" | |||
| "node": ">= 17" | |||
There was a problem hiding this comment.
@jamesmoschou this caused a regression on our end as well. just having it in the tree of a node v16.x project breaks during dependency installation (yarn, in our case), even if we don't directly use this package.
EDIT: nvmind found #298
Fixes CI tests, as much as possible from a forked repo.
Note: This PR bumps the minimum Node version from 12 to 17. This is because browser tests use an older version of Webpack that requires
NODE_OPTIONS=--openssl-legacy-providerto be specified when using recent versions of Node. However this option does not exist in older version of Node.