Ensure parsed e-mail message is not discarded #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
issue/66-fix-lost-information
branch
4 times, most recently
from
8ff1be4
to
36d2f7f
Compare
sergei-maertens
changed the title
sastred
reviewed
Aug 9, 2023
tests/tests/test_models.py
Outdated
| b"\x00\x00\x00\rIDAT\x18Wc\xf8\xff\xef\xdf\x7f\x00\t\xf6\x03\xfbW\xfe{\x1b" | ||
| b"\x00\x00\x00\x00IEND\xaeB`\x82" | ||
| ) | ||
| image.add_header("Content-ID", f"<123456789>") |
There was a problem hiding this comment.
This is a bit nit, but flake8 is complaining about the f-string: f-string is missing placeholdersflake8(F541).
There was a problem hiding this comment.
no worries, I aim to comply to flake8! It used to be an interpolated thing but I updated it afterwards.
As for flake8 and the likes - have you considered adding the check to CI? I checked but couldn't find anything for isort/black either.
There was a problem hiding this comment.
Yes, we have considered adding at least flake8 and we will probably do it in the future. Not 100% sure about adding black and reformat all the code.
BCC addresses are not included in e-mail headers, as this would disclose the other recipients, breaking the 'blind' aspect. As such, there is no point in trying to read this from the parsed email, it will never yield valid addresses. Removing the line removes confusion and prevents wrong impressions.
Message reconstruction from string dropped custom headers and particular attachment content disposition/relations.
sergei-maertens
force-pushed
the
issue/66-fix-lost-information
branch
from
47198d0
to
c535118
Compare
sastred
approved these changes
Aug 10, 2023
|
Closes #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #66
The custom header treatment feels a bit fragile, though I do believe that: