⚡ Fixes #68 -- improve performance of data migration #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested against a 13GB SQL dump of the email table (~23K records), within a cgroup with 300M memory limit. The migration completed in just under 60s. * Use iterator to avoid loading entire table in memory (for the queryset cache) * Defer the message content, as it may contain attachments causing excessive memory usage - it is not used in the migration anyway. * Replace loop over log table with 3 separate SQL update queries
|
@sergei-maertens can confirm that this works. Migration took about a minute. Thanks! |
|
Nice! Feel free to add the no-op backwards migrations. |
Discussed in the context of APSL#68 - the reverse data migration is not implemented (deliberately), but that shouldn't prevent people from rolling back their migrations in dev-environments and while debugging/diagnosing issues, for example.
I've added it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against a 13GB SQL dump of the email table (~23K records), within a cgroup with 300M memory limit. The migration completed in just under 60s.