New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify puput layout, configurable default template color and social link sharing #154
Conversation
@marctc, I've update the documentation. Can you take a look? |
README.rst
Outdated
@@ -35,8 +35,11 @@ Features | |||
* RSS feeds | |||
* Related entries | |||
* Extensible entry model | |||
* Configurable main color |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configurable default template color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
e2c96d8
to
4cf36e3
Compare
I've check the compability with Django 2.0 and Wagtail 2.0. |
puput/templates/puput/blog_page.html
Outdated
</section> | ||
</article> | ||
{% empty %} | ||
<span>{% trans 'No results found.' %}</span> | ||
<span>{% trans 'No results founds.' %}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
founds - found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
<h3> | ||
<a href="{% entry_url related_entry blog_page %}">{{ related_entry.title }}</a> | ||
</h3> | ||
<p> | ||
{{ related_entry.body|richtext|truncatewords:20 }} | ||
{{ related_entry.body|richtext|truncatewords:20 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra white space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
<link rel="stylesheet" href="{% static 'wagtailadmin/css/layouts/page-editor.css' %}" type="text/css" /> | ||
<link rel="stylesheet" href="{% static 'wagtailadmin/css/panels/rich-text.css' %}" type="text/css" /> | ||
|
||
<!--TODO: style color selector !!!!--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be removed 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@marctc I've corrected the issues that you've pointed. |
As it was talk with @marctc this PR proposes a modification of puput layout.
In addition, a main color selector has been added in the blog model.
Moreover, social sharing links has been included in blog entries.
There are some work to do before the acceptance of this PR: