Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform componentWillReceiveProps to componentDidUpdate #354

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Transform componentWillReceiveProps to componentDidUpdate #354

merged 1 commit into from
Aug 14, 2019

Conversation

KarlosQ
Copy link
Contributor

@KarlosQ KarlosQ commented May 8, 2019

Transform componentWillReceiveProps to componentDidUpdate because componentWillReceiveProps is deprecated

@kimihiro64
Copy link

Can we get this in soon? After RN 60 upgrade, getting yellowbox warning for it, and I use it on every screen ;_;. @alvaromb

@smxdevst
Copy link

Please merge

@zolero
Copy link

zolero commented Aug 1, 2019

Merge this please...

@ryardley
Copy link

ryardley commented Aug 2, 2019

If the maintainer is waiting for more testing at least use UNSAFE_componentWillReceiveProps to silence the warning otherwise it would be good to merge this asap.

@Cplantijn
Copy link

it'll be great to see this merged!

@morgondag
Copy link

gimmy <3

@alvaromb alvaromb merged commit 8c3d10d into APSL:master Aug 14, 2019
@alvaromb
Copy link
Collaborator

Sorry for the delay people, merged. Will release in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants