Fix reference errors in THREE.Math and THREEx #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2023
Closed
|
Hi @Hyeonoo-Park I will review and will check the code in the next days when i have a bit of time. |
|
Hi @Hyeonoo-Park I tested your changes, and as @DougReeder pointed out in this PR #525 the aframe version used in the examples need to be upgraded to 1.3.0 can you make these changes for all the examples (location, markers and nft) ? |
kalwalt
reviewed
Mar 15, 2023
aframe/src/new-location-based/arjs-device-orientation-controls.js
Outdated
Show resolved
Hide resolved
|
All the aframe examples will need to upgrade the Aframe version but i can do this. If nothing against @nickw1 i will merge this. POST-EDIT note: see this example is using aframe 1.0.4 but we upgraded to 1.3.0 and probably will raise an error. But anyway is better to use the same version to avoid confusion. |
kalwalt
changed the title
kalwalt
changed the title
kalwalt
approved these changes
Mar 21, 2023
aframe/src/new-location-based/arjs-device-orientation-controls.js
Outdated
Show resolved
Hide resolved
|
continue on #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix!
What kind of change does this PR introduce?
bugfix
Can it be referenced to an Issue? If so what is the issue # ?
Fixes #515
How can we test it?
See https://github.com/Hyeonoo-Park/react-ar-js-test sample project
Summary
Does this PR introduce a breaking change?
???
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Samsung Galaxy Note10+s(SM-N976N)
Chrome (110.0.5481.153)
Other information