Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathutils #525

Closed
wants to merge 2 commits into from
Closed

Mathutils #525

wants to merge 2 commits into from

Conversation

DougReeder
Copy link

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?
Updates A-Frame to v1.3.0 and uses the name MathUtils instead of Math, to resolve some lingering incompatibilities

Can it be referenced to an Issue? If so what is the issue # ?
#515
#515
incorporates #517

How can we test it?

I've run all the examples, and there are no Math/MathUtils errors.

Summary

  1. Math.sin(), etc. is the JavaScript builtin Math, while Math.degToRad() and Math.radToDeg() is three.js. Recent versions of three.js changed the name to MathUtils, to reduce the confusion.
  2. three.js v 0.146.0, the current dependency, uses the name MathUtils.
  3. A-Frame 1.0.4 is three years old, unsupported, and references the three.js methods using the name Math, so the dependency really ought to be updated

Does this PR introduce a breaking change?
No

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Examples run under MacOS 13.2.1, Firefox 110.0.1 (64-bit)

Other information

GordonSmith and others added 2 commits February 18, 2023 16:00
THREE.Math was renamed to THREE.MathUtils in r113.
THREE.PlaneBufferGeometry is deprecated.

Fixes AR-js-org#515

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@kalwalt
Copy link
Member

kalwalt commented Mar 10, 2023

There is already a PR for this why open a new one?

@DougReeder
Copy link
Author

Closed in favor of #523 (albeit, the A-Frame version should still be updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants